Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict type checking #685

Open
14 of 19 tasks
millnut opened this issue Mar 3, 2024 · 0 comments
Open
14 of 19 tasks

Add strict type checking #685

millnut opened this issue Mar 3, 2024 · 0 comments

Comments

@millnut
Copy link
Member

millnut commented Mar 3, 2024

Drupal is moving towards strict type (https://www.drupal.org/project/drupal/issues/3404246, https://www.drupal.org/project/drupal/issues/3295295).

I have started adding improvements to PHPStan checks to run strict type checking, as part of this it includes a new dev package in the project called phpstan/phpstan-strict-rules. By default I've disabled most of the rules it provides apart from checking calls are strict.

The checks can be found in this PR localgovdrupal/localgov_project#153 where the previous deprecated check is now a static analysis check to report all modules for deprecations, strict calls and typing.

Overall there are only 129 strict type/call issues which is great as this means minimal work to update.

This ticket would be best used to track updating each module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant