Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict types support #148

Closed
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #153
Closed
Tracked by #685

Strict types support #148

millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #153

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info I've added a test pipeline in preparation localgovdrupal/localgov_project#153 which has highlighted some failures which we should fix.

 ------ -------------------------------------------------------------- 
  Line   modules/contrib/localgov_guides/localgov_guides.module        
 ------ -------------------------------------------------------------- 
  180    Call to function in_array() requires parameter #3 to be set.  
  181    Call to function in_array() requires parameter #3 to be set.  
 ------ -------------------------------------------------------------- 

 ------ ------------------------------------------------------------------ 
  Line   modules/contrib/localgov_guides/src/ChildParentRelationship.php   
 ------ ------------------------------------------------------------------ 
  64     Call to function array_keys() requires parameter #3 to be set.    
  87     Call to function array_keys() requires parameter #3 to be set.    
  96     Call to function array_search() requires parameter #3 to be set.  
 ------ ------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_guides/tests/src/Kernel/OverviewPageIntegrity.php  
 ------ ---------------------------------------------------------------------------- 
  55     Call to method Drupal\KernelTests\KernelTestBase::setUp() with              
         incorrect case: setup                                                       
  100    Call to function array_search() requires parameter #3 to be set.            
  101    Call to function array_search() requires parameter #3 to be set.            
  120    Call to function array_search() requires parameter #3 to be set.            
  121    Call to function array_search() requires parameter #3 to be set.            
  122    Call to function array_search() requires parameter #3 to be set.            
 ------ ---------------------------------------------------------------------------- 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant