Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining strict types errors #75

Closed
millnut opened this issue Aug 29, 2024 · 1 comment
Closed

Fix remaining strict types errors #75

millnut opened this issue Aug 29, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@millnut
Copy link
Member

millnut commented Aug 29, 2024

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -----------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_search/modules/localgov_search_db/tests/Kernel/InstallTest.php
 ------ -----------------------------------------------------------------------------------------
  34     Call to method Drupal\KernelTests\KernelTestBase::setUp() with incorrect case: setup
 ------ -----------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_search/tests/src/Kernel/ContentTypesAddedToSearchTest.php
 ------ --------------------------------------------------------------------------------------
  39     Call to method Drupal\KernelTests\KernelTestBase::setUp() with incorrect case: setup
 ------ --------------------------------------------------------------------------------------
@millnut millnut added the good first issue Good for newcomers label Aug 29, 2024
@millnut
Copy link
Member Author

millnut commented Oct 12, 2024

Closing this issue as this has been fixed

@millnut millnut closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant