Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict types support #49

Closed
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #52
Closed
Tracked by #685

Strict types support #49

millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #52

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info I've added a test pipeline in preparation localgovdrupal/localgov_project#153 which has highlighted some failures which we should fix.

 ------ --------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_page_components/src/Plugin/Linkit/Matcher/PageComponentMatcher.php  
 ------ --------------------------------------------------------------------------------------------- 
  170    Call to function in_array() requires parameter #3 to be set.                                 
 ------ ---------------------------------------------------------------------------------------------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: strict types support localgovdrupal/localgov_page_components
1 participant
@millnut