Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining strict types errors #34

Closed
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #45
Closed
Tracked by #685

Fix remaining strict types errors #34

millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #45
Labels
good first issue Good for newcomers

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/localgov_menu_link_group.module
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  91     Parameter #2 $callback of function array_walk expects callable(Drupal\Core\Entity\EntityInterface, int|string): mixed, array{Drupal\localgov_menu_link_group\MenuLinkGrouper, 'groupChildMenuLinks'} given.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/src/Controller/LocalGovMenuLinkGroupListBuilder.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  51     Parameter #1 $group of method Drupal\localgov_menu_link_group\Controller\LocalGovMenuLinkGroupListBuilder::determineParentMenuLinkLabel() expects Drupal\localgov_menu_link_group\Entity\LocalGovMenuLinkGroupInterface,
         Drupal\Core\Entity\EntityInterface given.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/src/Form/LocalGovMenuLinkGroupForm.php
 ------ ------------------------------------------------------------------------------------------------------------------------
  80     Dynamic call to static method Drupal\localgov_menu_link_group\Form\LocalGovMenuLinkGroupForm::prepareMenuLinkOption().
 ------ ------------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/tests/src/Kernel/GroupAccessTest.php
 ------ -------------------------------------------------------------------------------
  64     Class DOMXPath referenced with incorrect case: DomXPath.
  79     Class DOMXPath referenced with incorrect case: DomXPath.
 ------ -------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_menu_link_group/tests/src/Kernel/GroupConfigImportTest.php
 ------ -------------------------------------------------------------------------------------
  45     Call to function in_array() requires parameter #3 to be set.
  72     Call to function in_array() requires parameter #3 to be set.
 ------ -------------------------------------------------------------------------------------
@millnut millnut changed the title Strict types support Fix remaining strict types errors Aug 29, 2024
@millnut millnut added the good first issue Good for newcomers label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant