Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining strict types errors #369

Closed
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #401
Closed
Tracked by #685

Fix remaining strict types errors #369

millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #401
Labels
good first issue Good for newcomers

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/localgov_directories.install
 ------ -------------------------------------------------------------------
  195    Call to function array_search() requires parameter #3 to be set.
 ------ -------------------------------------------------------------------

 ------ ------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/localgov_directories.module
 ------ ------------------------------------------------------------------
  85     Call to function in_array() requires parameter #3 to be set.
 ------ ------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/modules/localgov_directories_db/tests/Kernel/InstallTest.php
 ------ ---------------------------------------------------------------------------------------------------
  42     Call to method Drupal\KernelTests\KernelTestBase::setUp() with incorrect case: setup
 ------ ---------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/modules/localgov_directories_location/localgov_directories_location.module
 ------ -----------------------------------------------------------------------------------------------------------------
  65     Call to function in_array() requires parameter #3 to be set.
 ------ -----------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/modules/localgov_directories_location/src/ProximitySearchSetup.php
 ------ ---------------------------------------------------------------------------------------------------------
  86     Call to function in_array() requires parameter #3 to be set.
 ------ ---------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/modules/localgov_directories_or/src/FacetMapping.php
 ------ -------------------------------------------------------------------------------------------
  79     Call to function in_array() requires parameter #3 to be set.
  95     Call to function in_array() requires parameter #3 to be set.
 ------ -------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/src/ConfigurationHelper.php
 ------ ------------------------------------------------------------------
  447    Call to function in_array() requires parameter #3 to be set.
  472    Call to function array_search() requires parameter #3 to be set.
 ------ ------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/src/Plugin/Block/ChannelSearchBlock.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  183    Parameter #2 $callback of function array_reduce expects callable(array<string>, Drupal\Core\Entity\EntityInterface): array<string>, Closure(array, Drupal\node\NodeInterface): array<string> given.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/src/Plugin/facets/query_type/LocalGovDirectoriesQueryType.php
 ------ ----------------------------------------------------------------------------------------------------
  27     Variable $query in empty() always exists and is not falsy.
  51     Variable $bundle might not be defined.
  96     Call to function in_array() requires parameter #3 to be set.
  160    Call to function in_array() requires parameter #3 to be set.
  190    Call to function in_array() requires parameter #3 to be set.
 ------ ----------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/tests/src/Functional/FacetsTest.php
 ------ -------------------------------------------------------------------------------------------
  83     Method Drupal\Tests\BrowserTestBase::drupalLogout() invoked with 1 parameter, 0 required.
 ------ -------------------------------------------------------------------------------------------

 ------ ------------------------------------------------------------------------------
  Line   modules/contrib/localgov_directories/tests/src/Unit/FacetPreprocessTest.php
 ------ ------------------------------------------------------------------------------
  70     Call to method Drupal\Tests\UnitTestCase::setUp() with incorrect case: setup
 ------ ------------------------------------------------------------------------------
@millnut millnut added the good first issue Good for newcomers label Aug 29, 2024
@millnut millnut changed the title Strict types support Fix remaining strict types errors Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant