Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining strict types errors #114

Open
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments
Open
Tracked by #685

Fix remaining strict types errors #114

millnut opened this issue Mar 21, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info we should fix the remaining errors suppressed in the phpstan baseline.

 ------ -------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_address/tests/Functional/AddressFormsTest.php
 ------ -------------------------------------------------------------------------------------------------
  107    Call to static method Drupal\Component\Utility\Html::escape() with incorrect case: Escape
 ------ -------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_update/src/MigrateDisplayModes.php
 ------ --------------------------------------------------------------------------------------
  200    Variable $new_config in empty() is never defined.
  201    Undefined variable: $new_config
  224    Variable $new_base_array might not be defined.
  227    Variable $new_base_array might not be defined.
 ------ --------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_update/tests/modules/localgov_geo_update_to_geo_test/src/Element/AutocompleteAddress.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------
  75     Variable $url might not be defined.
  76     Variable $url might not be defined.
 ------ --------------------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   modules/contrib/localgov_geo/modules/localgov_geo_update/tests/modules/localgov_geo_update_to_geo_test/src/Plugin/Field/FieldWidget/AutocompleteAddress.php
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  255    Parameter #2 $callback of function uasort expects callable(Drupal\Core\Entity\EntityInterface, Drupal\Core\Entity\EntityInterface): int, Closure(Drupal\geocoder\Entity\GeocoderProvider, Drupal\geocoder\Entity\GeocoderProvider): (-1|0|1) given.
 ------ -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
@millnut millnut changed the title Strict types support Fix remaining strict types errors Aug 29, 2024
@millnut millnut added the good first issue Good for newcomers label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant