Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict types support #83

Closed
Tracked by #685
millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #105
Closed
Tracked by #685

Strict types support #83

millnut opened this issue Mar 21, 2024 · 0 comments · Fixed by #105

Comments

@millnut
Copy link
Member

millnut commented Mar 21, 2024

With Drupal core moving towards strict types, more info I've added a test pipeline in preparation localgovdrupal/localgov_project#153 which has highlighted some failures which we should fix.

 ------ --------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/localgov_workflows.install  
 ------ --------------------------------------------------------------- 
  62     Call to function in_array() requires parameter #3 to be set.   
  126    Call to function in_array() requires parameter #3 to be set.   
 ------ --------------------------------------------------------------- 

 ------ -------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/localgov_workflows.module  
 ------ -------------------------------------------------------------- 
  22     Call to function in_array() requires parameter #3 to be set.  
  122    Call to function in_array() requires parameter #3 to be set.  
  126    Call to function in_array() requires parameter #3 to be set.  
 ------ -------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/modules/localgov_review_date/localgov_review_date.module  
 ------ --------------------------------------------------------------------------------------------- 
  21     Call to function in_array() requires parameter #3 to be set.                                 
 ------ --------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/modules/localgov_review_date/tests/src/Kernel/ReviewDateEntityTest.php  
 ------ ----------------------------------------------------------------------------------------------------------- 
  56     Call to method Drupal\KernelTests\KernelTestBase::setUp() with                                             
         incorrect case: setup                                                                                      
 ------ ----------------------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Functional/WorkflowsAccessTest.php  
 ------ --------------------------------------------------------------------------------- 
  141    Parameter #1 $node of method                                                     
         Drupal\Tests\localgov_workflows\Functional\WorkflowsAccessTest::updateState()    
         expects Drupal\node\Entity\Node, Drupal\node\NodeInterface given.                
  154    Parameter #1 $node of method                                                     
         Drupal\Tests\localgov_workflows\Functional\WorkflowsAccessTest::updateState()    
         expects Drupal\node\Entity\Node, Drupal\node\NodeInterface given.                
 ------ --------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Kernel/WorkflowsEnableTest.php  
 ------ ----------------------------------------------------------------------------- 
  41     Call to method Drupal\KernelTests\KernelTestBase::setUp() with               
         incorrect case: setup                                                        
 ------ ----------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------ 
  Line   modules/contrib/localgov_workflows/tests/src/Kernel/WorkflowsInstallTest.php  
 ------ ------------------------------------------------------------------------------ 
  46     Call to method Drupal\KernelTests\KernelTestBase::setUp() with                
         incorrect case: setup                                                         
 ------ ------------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------------------------- 
  Line   modules/contrib/localgov_workflows/tests/src/Kernel/WorkflowsScheduledTransitionsTest.php  
 ------ ------------------------------------------------------------------------------------------- 
  45     Call to method Drupal\KernelTests\KernelTestBase::setUp() with                             
         incorrect case: setup                                                                      
 ------ ------------------------------------------------------------------------------------------- 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant