-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing text lines #2571
base: main
Are you sure you want to change the base?
Add missing text lines #2571
Conversation
@@ -101153,50 +101153,50 @@ UK: "Дозволяє викликати бомбардувальник B2 дл | |||
END | |||
|
|||
GUI:LoadReplayLong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you find out where this string was used in the R.G.Mechanics version? I think it originated from there when we copied Russian lang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have GUI:LoadReplay from which I took text lines. How can I find where this string was used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be referenced in one of the WND files of the R.G.Mechanics version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, there are no .wnd files after I installed R.G.Mechanics version. Where can I find them?
@@ -101219,34 +101219,34 @@ END | |||
|
|||
// context: Tooltip displayed when the user mouses over the Streak 3 battle honor icon | |||
TOOLTIP:BattleHonorStreak3Disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this string actually used in the screen?
It looks like there are generic strings with TOOLTIP:BattleHonorStreakDisabled, TOOLTIP:BattleHonorStreakOnlineDisabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to find out?
BP: "Temos uniformes bonitos... venha nos ver... você vai gostar.\nOu não." | ||
PL: "Mamy ładne mundury... przyjdź i zobacz nas... spodoba ci się.\nAlbo nie." | ||
RU: "У нас красивая униформа... приходите к нам... вам понравится.\nИли нет" | ||
AR: "لدينا زي رسمي لطيف... تعال وشاهدنا... سوف يعجبك.\nأو لا." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arabic text is right to left, so it seems odd that sentences start with a dot. Several times in this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed all
PL: "Medal za dobrą passę\nGracz zwyciężył w 5 kolejnych potyczkach.\nMedal ten otrzymuje się za 3, 10, 25, 100, 500 i 1000 zwycięstw pod rząd." | ||
RU: "Медаль за стойкость(3)\nИгрок победил 5 раза подряд в одиночных или коллективных играх через интернет" | ||
AR: "Streak Honor\nPlayer has won 5 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins" | ||
UK: "Відзнака серії\nГравець виграв 5 сутички поспіль\nОтримайте нову відзнаку за 3, 10, 25, 100, 500 і 1000 перемог поспіль" | ||
END | ||
|
||
// context: Tooltip displayed when the user mouses over the Streak 20 battle honor icon | ||
TOOLTIP:BattleHonorStreak20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tool tip actually used in the game? If yes, then the number list for "Earn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins" would need updating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PL: "" | ||
RU: "Медаль за Стойкость\nВыиграйте 3 или более игр подряд, чтобы получить эту медаль" | ||
AR: "" | ||
US: "Streak Honor\nPlayer has won 3 Skirmish games in a row\nEarn a new medal for 3, 10, 25, 100, 500 & 1000 consecutive wins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this description is correct. It probably should be closer to TOOLTIP:BattleHonorStreakDisabled
. But I suspect it is unused and therefore we do not need a text. But I do not know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -101153,50 +101153,50 @@ UK: "Дозволяє викликати бомбардувальник B2 дл | |||
END | |||
|
|||
GUI:LoadReplayLong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be referenced in one of the WND files of the R.G.Mechanics version.
28.02.25 fixes
01.03 Removed Arabic lines
I removed all added Arabic lines in this change. They will be added separately after we get Arabic loca working properly. |
01.03 numbers fixed
Edits only to TBD lines and empty lines at the end of generals str