English and various localization fixes and improvements #2535
Conversation
New edits
xezon
added
Minor
xezon
changed the title
new comments
All comments to US edits are done
There was a problem hiding this comment.
Overall: This language edit does too many different things. There are some edits, where I have asked if other languages have been tweaked as well, which would be better suited for separate changes where all languages are edited in one go.
Why? Because it makes it much easier to review, and classify as a single change, aka it is easier to see in the commit history, easier to revert and also easier to create a matching yaml file with change descriptions for.
Here is an example of how a change that touches one specific thing:
https://github.com/TheSuperHackers/GeneralsGamePatch/pull/2352/files
|
|
||
| CONTROLBAR:AirF_ToolTipUSABuildStealthFighter | ||
| US: "Stealthed while moving\nEquipped with a Point Defense Laser\n\nStrong vs. base defenses\nWeak vs. rocket soldiers" | ||
| US: "Stealthed\nEquipped with a Point Defense Laser\n\nStrong vs. base defenses\nWeak vs. rocket soldiers" |
There was a problem hiding this comment.
This this also tweaked for the other languages?
| // context: Tooltip for the button that refreshes teh game and player lists | ||
| TOOLTIP:RefreshGamePlayerList | ||
| US: "" | ||
| US: "Update list of games and players" |
There was a problem hiding this comment.
All the missing strings added here ideally are done in a separate change for all languages in one go.
Changes v1
Comments addressed
Carpet edits
| // context: Tooltip displayed when the user mouses over the Streak 3 battle honor icon | ||
| TOOLTIP:BattleHonorStreak3Disabled | ||
| US: "" | ||
| DE: "Siegesmedaille\nFür diese Auszeichnung musst du 3 Spiele in Folge gewinnen." | ||
| DE: "" |
There was a problem hiding this comment.
This probably should not remove DE texts here.
| @@ -101294,6 +101503,8 @@ AR: "" | |||
| UK: "" | |||
| END | |||
|
|
|||
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "" (#2535) | |||
There was a problem hiding this comment.
There are a bunch of change comments without changes here.
| @@ -100220,9 +100418,10 @@ UK: "Реактор забезпечує на 300% більше енергії" | |||
| END | |||
|
|
|||
| // Patch104p @fix xezon 26/07/2023 Removes superfluous mention of "enemy" for US, DE, FR, ES, BP, PL, RU, UK. (#2167) (#2519) | |||
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "Stealthed while moving\nEquipped with a Point Defense Laser\n\nStrong vs. base defenses\nWeak vs. rocket soldiers" (#2535) | |||
There was a problem hiding this comment.
Perhaps can simplify comment with Changes first US sentence from "Stealthed while moving"
Other than that, original text was different, because comment above does say that "enemy" was removed.
| @@ -56782,9 +56918,10 @@ UK: "Стріляє протиракетним лазером" | |||
| END | |||
|
|
|||
| // Patch104p @fix xezon 20/08/2023 Improves wording for US, ES, IT, BP. (#2261) | |||
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "Heavy lift transport\nupgrades with base defense structures and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" (#2535) | |||
There was a problem hiding this comment.
Can remove this comment and append (#2535) to comment above.
| @@ -51366,7 +51498,7 @@ END | |||
| // Patch104p @fix xezon 20/08/2023 Fix name discrepancies with CONTROLBAR:UpgradeSuicideBomb for all latin languages. (#2250) | |||
|
|
|||
| HELP:Demolitions-01 | |||
| US: "HINT:\nThe Demolitions ability enables all units to detonate" | |||
| US: "HINT:\nThe Demolitions ability enables all units to detonate after death or at your command" | |||
There was a problem hiding this comment.
The other languages are still closer to what the original English said.
| @@ -58387,10 +58528,12 @@ AR: "2030-200403-1" | |||
| UK: "2030-200403-1" | |||
| END | |||
|
|
|||
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "TBD" (#2535) | |||
There was a problem hiding this comment.
This comment is wrong. Several times in this file.
| DE: "Wo sind meine Truppen? Bitte lassen Sie mich laufen, ja? Tun Sie mir nicht weh!" | ||
| FR: "Inconnu" | ||
| DE: "TBD" | ||
| FR: "TBD" |
There was a problem hiding this comment.
This change touches DE and FR several times unexpectedly.
| @@ -96744,9 +96932,10 @@ UK: "Відсоток виграшу для кожної армії на осн | |||
| END | |||
|
|
|||
| // Patch104p @fix xezon 20/08/2023 Improves wording for US, ES, IT, BP. (#2261) | |||
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "Heavy lift transport\nupgrades with base defense structures and Nuke Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" (#2535) | |||
There was a problem hiding this comment.
Can remove this comments and append (#2535) to comment above.
|
|
||
| CONTROLBAR:Infa_ToolTipChinaBuildHelix | ||
| US: "Heavy lift assault transport\nCan upgrade with Bunker and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. rocket soldiers, anti-air defenses" | ||
| US: "Heavy lift assault transport\nCan upgrade with Bunker and Napalm Bombs\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" |
There was a problem hiding this comment.
This was meant to say "rocket soldiers" for consistency.
| @@ -97693,9 +97882,10 @@ END | |||
| // Patch104p @fix xezon 20/08/2023 Improves wording for US, ES, IT, BP. (#2261) | |||
| // Patch104p @fix xezon 20/08/2023 Removes incorrect upgrade information for all latin languages. (#2261) | |||
| // Patch104p @fix xezon 20/08/2023 Removes incorrect bunker information in PL. (#2261) | |||
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "Heavy lift assault transport\nupgrades with base defense structures and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. missile armed infantry, anti-air defenses" (#2535) | |||
There was a problem hiding this comment.
Remove this comment and append (#2535) to first comment above.
|
|
||
| CONTROLBAR:ToolTipChinaBuildHelix | ||
| US: "Heavy lift transport\nCan upgrade with base defense structures and Napalm Bomb\n\nStrong vs. tanks, light vehicles\nWeak vs. rocket soldiers, anti-air defenses" | ||
| US: "Heavy lift transport\nCan upgrade with base defense structures and Napalm Bombs\n\nStrong vs. tanks, light vehicles\nWeak vs. rocket soldiers, anti-air defenses" |
There was a problem hiding this comment.
Is this also changed to plural in the other languages? DE, FR already are plural.
| MAP:MD-USA06Warning17 | ||
| US: "WARNING:\nDr. Thrax has been known to use a Sneak Attack\nTunnel Network to surprise enemies" |
There was a problem hiding this comment.
I am not sure if removing "Tunnel Network" is better here. The other languages also mention tunnel networks. And technically the Sneak Attack is a Tunnel Network.
| SCIENCE:Nuke_ChinaCarpetBomb | ||
| US: "Nuke Bomber" | ||
| US: "Nuke Carpet Bomber" |
There was a problem hiding this comment.
I do not understand the question.
01.03 comment changes
|
|
||
| // context: Appears when you mouse over the Bio Bomb Upgrade cameo on the GLA Bomb Truck | ||
| CONTROLBAR:TooltipGLAUpgradeBioBomb | ||
| US: "This Bomb Truck becomes a biowar weapon with 25% more range" | ||
| US: "This Bomb Truck becomes a bioweapon and improves its explosion range by 25%" |
There was a problem hiding this comment.
| US: "This Bomb Truck becomes a bioweapon and improves its explosion range by 25%" | |
| US: "This Bomb Truck becomes a bioweapon and increases its explosion range by 25%" |
| @@ -30509,7 +30563,7 @@ END | |||
|
|
|||
| // context: Appears when you mouse over the Wall cameo on the USA Dozer | |||
| CONTROLBAR:ToolTipUSABuildWall | |||
| US: "USA fence system. Laser-sensors alert to enemy troops moving through fence. Fence blocks enemy vehicle movement" | |||
| US: "USA fence system. Laser-sensors alert when enemy troops move through the fence. Fence blocks enemy vehicle movement" | |||
There was a problem hiding this comment.
| US: "USA fence system. Laser-sensors alert when enemy troops move through the fence. Fence blocks enemy vehicle movement" | |
| US: "USA fence system. Laser-sensors alert when enemy troops move through the fence. Fences block enemy vehicle movement" |
|
|
||
| // context: Appears when you mouse over the Nuke Cannon cameo on the Chinese General Points Command Bar | ||
| CONTROLBAR:ToolTipChinaScienceNukeCannon | ||
| US: "Nuke Cannons lob small tactical nukes great distances\n\nBuild at: War Factory" | ||
| US: "Nuke Cannons lob small tactical nukes at great distances\n\nBuild at: War Factory" |
There was a problem hiding this comment.
| US: "Nuke Cannons lob small tactical nukes at great distances\n\nBuild at: War Factory" | |
| US: "Nuke Cannons lob small tactical nukes over great distances\n\nBuild at: War Factory" |
|
|
||
| CONTROLBAR:Demo_ToolTipGLAScienceRebelAmbush | ||
| US: "Allows you to create a surprise ambush of Rebels anywhere\n\nRank 1: 4 Rebels\nRank 2: 6 Rebels\nRank 3: 10 Rebels\n\nDeploy from: Command Center" | ||
| US: "Creates a surprise ambush of Rebels anywhere\n\nRank 1: 4 Rebels\nRank 2: 6 Rebels\nRank 3: 10 Rebels\n\nDeploy from: Command Center" |
There was a problem hiding this comment.
Flows better with placement specificity.
| US: "Creates a surprise ambush of Rebels anywhere\n\nRank 1: 4 Rebels\nRank 2: 6 Rebels\nRank 3: 10 Rebels\n\nDeploy from: Command Center" | |
| US: "Creates a surprise ambush of Rebels anywhere on the map\n\nRank 1: 4 Rebels\nRank 2: 6 Rebels\nRank 3: 10 Rebels\n\nDeploy from: Command Center" |
| MAP:TrainingSalvage | ||
| US: "You have created a pile of salvage. Whenever GLA vehicles destroy enemy vehicles salvage is left behind. GLA vehicles can pick up salvage by moving over it. Salvage may be worth money or experience. Technicals, Quad Cannons and Marauders can upgrade their weapons with salvage" | ||
| US: "You have created a pile of salvage. Whenever GLA vehicles destroy enemy vehicles, salvage is left behind. GLA vehicles can pick up salvage by moving over it. Salvage may be worth money or experience. Technicals, Quad Cannons and Marauders can upgrade their weapons with salvage" |
There was a problem hiding this comment.
Should we address the absence of SCUD Launchers, Toxin Tractors, Scorpions and Battle Buses?
| // Patch104p @fix dmgreen 06/12/2024 Changes US from "" (#2535) | ||
|
|
There was a problem hiding this comment.
These are all unnecessary?
| // context: Error. The game the player was traying to connect has disapeared from the lobby | ||
| LAN:ErrorGameGone | ||
| US: "Game has dissappeared" | ||
| US: "Game has disappeared" |
There was a problem hiding this comment.
| US: "Game has disappeared" | |
| US: "The game has disappeared" |
| // context: Joins quickmatch. | ||
| TOOLTIP:Quickmatch | ||
| US: "Click to begin QuickMatch. QuickMatch will attempt to automatically match you with your closest skill level and preferences" | ||
| US: "Click to begin QuickMatch. QuickMatch will attempt to automatically match you with a player who has the closest skill level and preferences" |
There was a problem hiding this comment.
| US: "Click to begin QuickMatch. QuickMatch will attempt to automatically match you with a player who has the closest skill level and preferences" | |
| US: "Click to begin QuickMatch. QuickMatch will attempt to automatically match you to a player with the closest skill level and preferences" |
| UPGRADE:AmericaLaserMissiles | ||
| US: "America Laser Missiles" | ||
| US: "Laser-guided Missiles" |
There was a problem hiding this comment.
The standard seems to be that hyphenated compound words are both capitalised in titles.
| US: "Laser-guided Missiles" | |
| US: "Laser-Guided Missiles" |
| HELP:SatelliteHack2-01 | ||
| US: "HINT:\nSatellite Hack 2 reveals all that enemy units can see" | ||
| US: "HINT:\nSatellite Hack 2 temporarily reveals all that enemy units can see" |
There was a problem hiding this comment.
Better to align with names / other instances.
| US: "HINT:\nSatellite Hack 2 temporarily reveals all that enemy units can see" | |
| US: "HINT:\nSatellite Hack II temporarily reveals all that enemy units can see" |
| LOAD:China05_3 | ||
| US: "- Call in Carpet Bombs and destroy the GLA" | ||
| US: "- Call in Carpet Bombers and destroy the GLA" |
There was a problem hiding this comment.
| US: "- Call in Carpet Bombers and destroy the GLA" | |
| US: "- Call in Carpet Bombers to assist with destroying the GLA bases" |
Might be more descriptive. This appears in the mission loading screen. The vanilla text implies that you have to use the bombers.
| OBJECT:TheLoo | ||
| US: "Out House" | ||
| US: "Loo" |
There was a problem hiding this comment.
In the US these are called Out Houses. Loo is UK English.
| MAP:TrainingSalvage | ||
| US: "You have created a pile of salvage. Whenever GLA vehicles destroy enemy vehicles salvage is left behind. GLA vehicles can pick up salvage by moving over it. Salvage may be worth money or experience. Technicals, Quad Cannons and Marauders can upgrade their weapons with salvage" | ||
| US: "You have created a pile of salvage. Whenever GLA vehicles destroy enemy vehicles, salvage is left behind. GLA vehicles can pick up salvage by moving over it. Salvage may be worth money or experience. Technicals, Quad Cannons and Marauders can upgrade their weapons with salvage" |
There was a problem hiding this comment.
| US: "You have created a pile of salvage. Whenever GLA vehicles destroy enemy vehicles, salvage is left behind. GLA vehicles can pick up salvage by moving over it. Salvage may be worth money or experience. Technicals, Quad Cannons and Marauders can upgrade their weapons with salvage" | |
| US: "You have created a pile of salvage. Salvage is left behind whenever GLA vehicles destroy an enemy vehicle. GLA vehicles pick up salvage by moving over it. Salvage may grant weapon upgrades, money, or experience. Technicals, Quad Cannons, and Marauders will upgrade their weapons with salvage. " |
- Switch from passive to active voice.
- Make it clearer what salvage doesn
| HELP:SentryDrone-02 | ||
| US: "HINT:\nPurchase the Sentry Done gun from the Strategy Center" | ||
| US: "HINT:\nPurchase the Sentry Done gun from the War Factory" |
There was a problem hiding this comment.
| US: "HINT:\nPurchase the Sentry Done gun from the War Factory" | |
| US: "HINT:\nPurchase the Sentry Drone machine-gun upgrade from the War Factory" |
| HELP:Avenger-02 | ||
| US: "HINT:\nAvengers are support units that can also attack aircraft" | ||
| US: "HINT:\nAvengers are support units that can neutralize missiles and attack aircraft" |
There was a problem hiding this comment.
| US: "HINT:\nAvengers are support units that can neutralize missiles and attack aircraft" | |
| US: "HINT:\nAvengers are support units that neutralize missiles, attack aircraft, and laser-designate ground targets" |
dmgreeny
changed the title
Changed simplified to traditional
|
All fixed |
English localization fixes and improvements
Authored by dmgreeny