Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMTP Configuration and Notification Mailers #427

Merged
merged 19 commits into from
Feb 21, 2025

Conversation

emmabjj
Copy link
Contributor

@emmabjj emmabjj commented Feb 19, 2025

Related tickets: #41 / #325 / #98 / #97

Add smtp configuration, ensuring the email system in local development uses the the local file system and doesn't require network access for automated testing and development purposes.

Mailers added:

  • Add mailer for new evaluation invitations and resend invitation
  • Add mailer to notify for a role request change after an evaluation invitation
  • Add mailer for recusal
  • Add mailer for new evaluation assignments and reassignments

Functionality included:

  • Email recipient is able to click on the "Login to Challenge.gov" button and redirected to challenge.gov.
  • The recusal mailer is sent to a challenge manager and has a link to the submission details page of the submission the evaluator recused themselves from.
  • The evaluation assignment mailer is sent to the evaluator and has a link to the submission new evaluation page.
  • The email is sent from [email protected] so that an evaluator can respond to the email if they need to request a role change.
  • The evaluation invitation mailer is sent when the invitation is resent from evaluators management by a challenge manager.
  • The evaluation assignment mailer is sent to the evaluator when a challenge manager reassigns them to a submission.

Something to note/Questions/Food for thought:

  • There can be more than one challenge manager assigned to a challenge, but the phase doesn't scope challenge managers, i.e. all phases include all the challenge managers in that challenge. The notification mailers include all challenge manager names and emails if there is more than one challenge manager assigned to that challenge. When an evaluator recuses themselves from a submission, all challenge managers for that challenge are included as recipients for that recusal mailer.
    ^
Screenshot 2025-02-18 at 9 53 24 PM
Screenshot 2025-02-18 at 9 39 59 PM
Screenshot 2025-02-18 at 9 40 14 PM
Screenshot 2025-02-18 at 9 41 19 PM
Screenshot 2025-02-18 at 9 40 57 PM

@emmabjj emmabjj self-assigned this Feb 19, 2025
@emmabjj emmabjj marked this pull request as ready for review February 20, 2025 17:21
@emmabjj emmabjj requested a review from stepchud February 20, 2025 17:22
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow very nice, I have very little code review feedback. will do some testing now.

@emmabjj emmabjj requested a review from stepchud February 21, 2025 01:44
stepchud
stepchud previously approved these changes Feb 21, 2025
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🎸

@stepchud stepchud dismissed their stale review February 21, 2025 03:06

hold on I just saw an exception

Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good, just had to restart my server

@stepchud stepchud merged commit 3cd187b into dev Feb 21, 2025
10 checks passed
@stepchud stepchud deleted the 41_add_SMTP_configuration_for_notifications branch February 21, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants