Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[129, 60, 130] Evaluation Form Model, Migration, CRUD, Responsive List View #169

Merged
merged 20 commits into from
Sep 27, 2024
Merged

[129, 60, 130] Evaluation Form Model, Migration, CRUD, Responsive List View #169

merged 20 commits into from
Sep 27, 2024

Conversation

stonefilipczak
Copy link
Contributor

@stonefilipczak stonefilipczak commented Sep 17, 2024 •
edited
Loading

This introduces the concept of evaluation forms to the application and allows a user to manipulate them through basic, un-styled views. It also implements a list view featuring a responsive table which collapses to a stacked table on mobile.

includes:

  • model
  • migration
  • routes
  • CRUD controller actions
  • basic CRUD views
  • responsive list view based on figma design
  • specs

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 09/24/24 milestone Sep 17, 2024
This was linked to issues Sep 24, 2024
Evaluation forms list #60
Closed
Evaluation Form: Create and Edit #61
Closed
Submission Evaluation View for Evaluators #90
Open
Create EvaluationForm model #129
Closed
Create a list view of EvaluationForms #130
Closed
This was unlinked from issues Sep 24, 2024
Evaluation Form: Create and Edit #61
Closed
Submission Evaluation View for Evaluators #90
Open
@stonefilipczak stonefilipczak changed the title [129++] Evaluation Form Model, Migration, CRUD [129, 60, 130] Evaluation Form Model, Migration, CRUD, Responsive List View Sep 24, 2024
stepchud
stepchud requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@stepchud stepchud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes and can we also add request specs for the index page:

  1. empty list
  2. rendering the list of forms when some exist
  3. list does not dispaly forms that don't belong to the user's challenges

app/controllers/evaluation_forms_controller.rb Outdated Show resolved Hide resolved
app/controllers/evaluation_forms_controller.rb Outdated Show resolved Hide resolved
app/controllers/evaluation_forms_controller.rb Show resolved Hide resolved
app/controllers/evaluation_forms_controller.rb Show resolved Hide resolved
app/models/evaluation_form.rb Outdated Show resolved Hide resolved
db/migrate/20240917010803_create_evaluation_forms.rb Outdated Show resolved Hide resolved
db/structure.sql Show resolved Hide resolved
db/migrate/20240917010803_create_evaluation_forms.rb Outdated Show resolved Hide resolved
spec/helpers/evaluation_forms_helper_spec.rb Outdated Show resolved Hide resolved
spec/models/evaluation_form_spec.rb Show resolved Hide resolved
@stepchud stepchud mentioned this pull request Sep 27, 2024
Merged
@stepchud stepchud merged commit 1271dbd into dev Sep 27, 2024
11 checks passed
@stepchud stepchud deleted the 129_evaluation_form branch September 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepchud stepchud stepchud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Sprint 10/08/24
Development

Successfully merging this pull request may close these issues.

Create a list view of EvaluationForms Create EvaluationForm model Evaluation forms list
3 participants
@stonefilipczak @stepchud @r-bartlett-gsa