Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EvaluationForm model #129

Closed
Tracked by #60
stepchud opened this issue Aug 21, 2024 · 3 comments · Fixed by #169
Closed
Tracked by #60

Create EvaluationForm model #129

stepchud opened this issue Aug 21, 2024 · 3 comments · Fixed by #169
Assignees
Labels

Comments

@stepchud
Copy link
Contributor

stepchud commented Aug 21, 2024

Description

This model will store the forms that challenge managers create, edit and publish for evaluation of their challenges.

Attributes

attribute type options
challenge_id :id belongs_to :challenge
title string null: false
instructions string null: false
challenge_phase small_int null: false
status enum(:draft, :ready, :published) default :draft
comments_required bool default: false
weighted_scoring bool default: false
publication_date date null: true
closing_date date null: true

add_index(:evaluation_forms, [:challenge_id, :challenge_phase], unique: true)

Validations

title, instruction, challenge_id, challenge_phase are required.
The <challenge_id, challenge_phase> pairing is unique.

Tests

Add a factory helper for conveniently creating models in specs. Add specs for creating, updating, destroying, validating.

Out of Scope

The EvaluationForm class has_many :evaluation_form_criteria, however that will be added in another task.

@stepchud stepchud mentioned this issue Aug 21, 2024
57 tasks
@stonefilipczak stonefilipczak self-assigned this Sep 10, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 09/24/24 milestone Sep 11, 2024
@r-bartlett-gsa
Copy link
Member

@stonefilipczak / @stepchud In order to align evaluation period to the challenge end date, and make the dates less confusing the challenge manager, we eliminated publication date for the evaluation forms. This makes the form editable up until the challenge ends, and not needing to set the evaluation form status. So two of the attributes (status and publication_date) detailed in this card are not needed.

@stepchud
Copy link
Contributor Author

@r-bartlett-gsa there is no "Publish" button anymore?

@r-bartlett-gsa
Copy link
Member

@r-bartlett-gsa there is no "Publish" button anymore?

@stepchud That's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants