Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[129, 60, 130] Evaluation Form Model, Migration, CRUD, Responsive List View #169
[129, 60, 130] Evaluation Form Model, Migration, CRUD, Responsive List View #169
Changes from 4 commits
ee43b42
e6aa0cf
ef3b045
6cde22a
326ebff
ddacefa
0c4410d
58d2753
4f58427
69ff7f5
ba4816a
5affe56
b09a273
d2af7e9
0cd1d6e
b3b04d5
551ceba
aef614a
3c33990
a527388
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these stauts_colors aren't needed anymore, but if we do they should be matching the figma values, e.g. the green is
#4d8055
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can leave out the validations for now just to move this forward. based on the latest conversation with Renata, we will eventually run some validations only when the uses presses save, so it can't be tied to the Rails validation callbacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
status table column can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's avoid hard coding styles, especially for colors, and use a class such as
bg-green-primary
or something like that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove the custom route for now