-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add component defaults, rename templates to .in, rename ufs.configure for application, cleanup tests #2010
add component defaults, rename templates to .in, rename ufs.configure for application, cleanup tests #2010
Conversation
* clean up unnecessary quotes in tests
* shared namelist requires mom6 variables to be set
* remove orbital variables from atm-land case since these are used only for the ocean albedo calculation * move use_coldstart and use_mommesh to OCN attributes in config.in files since these are only used by mom6, removed from hafs cases *remove mediator_read_restart since this is not used by ufs *add some variables to tests where needed
…ture/templates_and_defaults
* data component tests use mix of input directory names, switch them all to just INPUT
* use CICE_,MOM6_,WW3_ prefixes for configurable items
* see issue 2015
* multigrid is never used for cmeps coupled applications but required for run_test.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additional templating of the configuration files.
The changes look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WW3 updates look good to me.
OK, I think we're good. The only files that I had to modify from the previous PR were to add the new MOM6 variables to the mom6 default export section and add them to the (renamed) MOM .IN files.
|
Sounds good. I'll get everything started then. |
Jenkins-ci ORTs passed |
Just noting that the hercules log shows a clean test because I turned off the troublesome |
Testing is complete, sending out final reviews. |
Following ufs-community#2010
PR Author Checklist:
Description
Renames various
template
files for the coupled model to be.IN
filesProvides component defaults for cice, mom6, cmeps and ww3 that can be re-used among applications instead of repeating the same defaults for each application
Renames
ufs.configure
files using the application (ie, s2s, s2swa) which uses themAdds
CICE_
,MOM6_
andWW3_
prefixes to many, but not all, configurable variablesAdds additional configuration settings for CICE,MOM6,CMEPS restart and output directories
Moves
use_coldstart
anduse_mommesh
from the ALLComp to the OCN attributes, since these are used only by MOM6Moves
eps_imesh
from the ALLComp to the ICE attributes since this is used only by ICE. Note MOM6 has a similar setting (eps_omesh) which is configured w/ a default value via MOM_input.gives MOM6 and CICE their own mesh file setting instead of
meshiceocn
since in upcoming configurations (regional MOM6, FVCOM etc) the ocean will not run with the ice model presentUses
INPUT
as input directory for all tests using CDEPS instead of various combinations ofINPUT_DATM
,DATM_INPUT
,INPUT_DOCN
etcremoves unnecessary quotes in tests
turns off
control_wrtGauss_netcdf_parallel_intel
test on hercules. See Issue multiple netcdf_parallel tests fail on hercules #2015Linked Issues and Pull Requests
Associated UFSWM Issue to close
Subcomponent Pull Requests
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Three tests fail but run to completion:
These tests fail only because the filename stored in a file has a changed directory name, ie
INPUT/sst.day.mean.2019.nc
vsINPUT_DOCN/sst.day.mean.2019.nc
. All other files for each of the failed tests is B4B:Hera RTs were re-run at 86415ba with identical results.
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: