Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional template variables for CICE namelist #1998

Closed

Conversation

aerorahul
Copy link
Contributor

@aerorahul aerorahul commented Nov 14, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

This PR:

  • adds a function export_cice6 in default_vars.sh defining additional template variables used in the CICE6 namelist ice_in_template. This is done to avoid repetition in the functions export_cpl and export_datm_cdeps
  • calls the function export_cice6 in export_cpl and export_datm_cdeps
  • updates the ice_in_template to templatize the additional variables defined in export_cice6.

This work is needed to allow the GFS/GEFS applications to use the model hosted templates.

Linked Issues and Pull Requests

This work is part of #1664

Subcomponent Pull Requests

None

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@DeniseWorthen
Copy link
Collaborator

I'd like to combine this with a similar fix for MOM6 and renaming the templates to .IN. Working on a testing branch now.

@jkbk2004 jkbk2004 mentioned this pull request Nov 17, 2023
42 tasks
@BrianCurtis-NOAA
Copy link
Collaborator

I think we're just waiting on a verification Hera log showing all baselines passing before this can be added to the commit queue or merged with another PR.

@BrianCurtis-NOAA BrianCurtis-NOAA added No Baseline Change No Baseline Change Incomplete This PR does not have all required information. Please see PR Author checklist. labels Nov 20, 2023
Copy link

@aerorahul please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

1 similar comment
Copy link

@aerorahul please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

@aerorahul
Copy link
Contributor Author

@aerorahul please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • fv3 NOT up to date

done.

@DeniseWorthen
Copy link
Collaborator

@aerorahul Please take a look at PR #2010, which incorporates this and other changes.

@aerorahul
Copy link
Contributor Author

@aerorahul Please take a look at PR #2010, which incorporates this and other changes.

@DeniseWorthen
The changes to ice_in.IN in #2010 are consistent with those in this PR.
Thank you for updating the other templates as well. That will need additional work in the global-workflow and we look forward to it.
I think this PR can be closed as the changes are incorporated in #2010

@aerorahul aerorahul closed this Nov 27, 2023
@aerorahul aerorahul deleted the feature/ufswm_templates branch February 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Incomplete This PR does not have all required information. Please see PR Author checklist. No Baseline Change No Baseline Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

export component defaults instead of application defaults for coupled configs
4 participants