Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atm+ocean+ice+aerosols S2SA regression test (cpld_s2sa_p8) #2009

Merged
merged 27 commits into from
Dec 13, 2023
Merged

Add atm+ocean+ice+aerosols S2SA regression test (cpld_s2sa_p8) #2009

merged 27 commits into from
Dec 13, 2023

Conversation

NickSzapiro-NOAA
Copy link
Collaborator

@NickSzapiro-NOAA NickSzapiro-NOAA commented Nov 24, 2023 •
edited by BrianCurtis-NOAA
Loading

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.
  • I am confirming reviews are completed in ALL sub-component PR's.
  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
    • LOG:
      Wed Nov 22 08:32:25 UTC 2023
      Start Regression test

Testing UFSWM Hash: b83a0e6
Testing With Submodule Hashes:
37cbb7d6840ae7515a9a8f0dfd4d89461b3396d1 AQM (v0.2.0-37-g37cbb7d)
2aa6bfbb62ebeecd7da964b8074f6c3c41c7d1eb CDEPS-interface/CDEPS (cdeps0.4.17-38-g2aa6bfb)
50aa2c97882fbc9d4918813a22169fe97b424564 CICE-interface/CICE (CICE6.0.0-444-g50aa2c9)
e5d08d4233b0c783a4840dcbc3252a170e3c3bb1 CMEPS-interface/CMEPS (cmeps_v0.4.1-1406-ge5d08d4)
cabd7753ae17f7bfcc6dad56daf10868aa51c3f4 CMakeModules (v1.0.0-28-gcabd775)
cd2c3b7ac0c613148ab2f956505b55f1d47a20ef FV3 (heads/develop)
041422934cae1570f2f0e67239d5d89f11c6e1b7 GOCART (sdr_v2.1.2.6-119-g0414229)
35789c757766e07f688b4c0c7c5229816f224b09 HYCOM-interface/HYCOM (2.3.00-121-g35789c7)
a36cb73d6924f6cf56a72b5799bef3d75fe4dd61 MOM6-interface/MOM6 (dev/master/repository_split_2014.10.10-9871-ga36cb73d6)
569e354ababbde7a7cd68647533769a5c966468d NOAHMP-interface/noahmp (v3.7.1-303-g569e354)
02693d837f2cd99d20ed08515878c2b5e9525e64 WW3 (6.07.1-343-g02693d83)
62b89146be1250f354cd50a14096c0c25f2f3952 stochastic_physics (ufs-v2.0.0-191-g62b8914)
Compile s2sa_gnu elapsed time 303 seconds. -DAPP=S2SA -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 -DMPI=ON -DCMAKE_BUILD_TYPE=Release -DMOM6SOLO=ON

baseline dir = /scratch1/NCEPDEV/stmp4/Nick.Szapiro/FV3_RT/REGRESSION_TEST/cpld_s2sa_p8_gnu
working dir = /scratch1/NCEPDEV/stmp2/Nick.Szapiro/FV3_RT/rt_180468/cpld_s2sa_p8_gnu
Checking test 001 cpld_s2sa_p8_gnu results ....
Moving baseline 001 cpld_s2sa_p8_gnu files ....
Moving sfcf024.tile1.nc .........OK
Moving sfcf024.tile2.nc .........OK
Moving sfcf024.tile3.nc .........OK
Moving sfcf024.tile4.nc .........OK
Moving sfcf024.tile5.nc .........OK
Moving sfcf024.tile6.nc .........OK
Moving atmf024.tile1.nc .........OK
Moving atmf024.tile2.nc .........OK
Moving atmf024.tile3.nc .........OK
Moving atmf024.tile4.nc .........OK
Moving atmf024.tile5.nc .........OK
Moving atmf024.tile6.nc .........OK
Moving gocart.inst_aod.20210323_0600z.nc4 .........OK
Moving RESTART/20210323.060000.coupler.res .........OK
Moving RESTART/20210323.060000.fv_core.res.nc .........OK
Moving RESTART/20210323.060000.fv_core.res.tile1.nc .........OK
Moving RESTART/20210323.060000.fv_core.res.tile2.nc .........OK
Moving RESTART/20210323.060000.fv_core.res.tile3.nc .........OK
Moving RESTART/20210323.060000.fv_core.res.tile4.nc .........OK
Moving RESTART/20210323.060000.fv_core.res.tile5.nc .........OK
Moving RESTART/20210323.060000.fv_core.res.tile6.nc .........OK
Moving RESTART/20210323.060000.fv_srf_wnd.res.tile1.nc .........OK
Moving RESTART/20210323.060000.fv_srf_wnd.res.tile2.nc .........OK
Moving RESTART/20210323.060000.fv_srf_wnd.res.tile3.nc .........OK
Moving RESTART/20210323.060000.fv_srf_wnd.res.tile4.nc .........OK
Moving RESTART/20210323.060000.fv_srf_wnd.res.tile5.nc .........OK
Moving RESTART/20210323.060000.fv_srf_wnd.res.tile6.nc .........OK
Moving RESTART/20210323.060000.fv_tracer.res.tile1.nc .........OK
Moving RESTART/20210323.060000.fv_tracer.res.tile2.nc .........OK
Moving RESTART/20210323.060000.fv_tracer.res.tile3.nc .........OK
Moving RESTART/20210323.060000.fv_tracer.res.tile4.nc .........OK
Moving RESTART/20210323.060000.fv_tracer.res.tile5.nc .........OK
Moving RESTART/20210323.060000.fv_tracer.res.tile6.nc .........OK
Moving RESTART/20210323.060000.phy_data.tile1.nc .........OK
Moving RESTART/20210323.060000.phy_data.tile2.nc .........OK
Moving RESTART/20210323.060000.phy_data.tile3.nc .........OK
Moving RESTART/20210323.060000.phy_data.tile4.nc .........OK
Moving RESTART/20210323.060000.phy_data.tile5.nc .........OK
Moving RESTART/20210323.060000.phy_data.tile6.nc .........OK
Moving RESTART/20210323.060000.sfc_data.tile1.nc .........OK
Moving RESTART/20210323.060000.sfc_data.tile2.nc .........OK
Moving RESTART/20210323.060000.sfc_data.tile3.nc .........OK
Moving RESTART/20210323.060000.sfc_data.tile4.nc .........OK
Moving RESTART/20210323.060000.sfc_data.tile5.nc .........OK
Moving RESTART/20210323.060000.sfc_data.tile6.nc .........OK
Moving RESTART/20210323.060000.MOM.res.nc .........OK
Moving RESTART/iced.2021-03-23-21600.nc .........OK
Moving RESTART/ufs.cpld.cpl.r.2021-03-23-21600.nc .........OK

0: The total amount of wall time = 547.138009
0: The maximum resident set size (KB) = 1469220

Test 001 cpld_s2sa_p8_gnu PASS

REGRESSION TEST WAS SUCCESSFUL
Wed Nov 22 11:10:08 UTC 2023
Elapsed time: 02h:37m:46s. Have a nice day!

  • I have added the list of all failed regression tests to "Anticipated changes" section.
  • I have filled out all sections of the template.

Description

Adds an atm+ocean+ice+aerosols S2SA regression test named cpld_s2sa_p8, following cpld_bmark_p8 and cpld_control_nowave_noaero_p8

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Closes #1817

Subcomponent Pull Requests

None

Blocking Dependencies

None

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR: New cpld_s2sa_p8 regression test

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@NickSzapiro-NOAA
Merge branch 'ufs-community:develop' into cpld_s2sa_p8
2d95133
@NickSzapiro-NOAA
Remove $MACHINE_ID lines
df2ec97 
No longer needed as reviewed by Denise, with Hera+gnu now working well w/ the normal wall-clock and Cheyenne retiring this month
@NickSzapiro-NOAA
Remove p8 label for ufs.configure.cpld_s2sa.IN
ca7d21a 
As reviewed by Denise, these config files are not specific to a certain physics configuration (and p8 will be outdated)
@NickSzapiro-NOAA
Remove p8 label from referenced configure file
dd35cb6
DeniseWorthen
DeniseWorthen reviewed Nov 28, 2023
View reviewed changes
tests/rt.conf Outdated Show resolved Hide resolved
DeniseWorthen
DeniseWorthen reviewed Nov 29, 2023
View reviewed changes
tests/rt.conf Outdated Show resolved Hide resolved
@NickSzapiro-NOAA
Remove compile for s2sa in rt.conf
db0edd2 
As suggested by Denise, reduce one compile job by using s2swa since whether waves are coupled or not is controlled via the namelist
@DeniseWorthen DeniseWorthen mentioned this pull request Nov 30, 2023
Closed
junwang-noaa
junwang-noaa previously approved these changes Dec 5, 2023
View reviewed changes
@DeniseWorthen
Copy link
Collaborator

@NickSzapiro-NOAA Have you tested that your new test compiles and runs correctly after removing the additional compile line and instead using the compile for s2swa?

@NickSzapiro-NOAA
Copy link
Collaborator Author

NickSzapiro-NOAA commented Dec 6, 2023 •
edited
Loading

@DeniseWorthen yes, /scratch1/NCEPDEV/stmp2/Nick.Szapiro/FV3_RT/rt_190832/

DeniseWorthen
DeniseWorthen previously approved these changes Dec 6, 2023
View reviewed changes
@NickSzapiro-NOAA
Copy link
Collaborator Author

@DeniseWorthen I've made these changes, following your #2010

DeniseWorthen
DeniseWorthen previously approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good now.

@DeniseWorthen DeniseWorthen mentioned this pull request Dec 11, 2023
Closed
@DeniseWorthen
Copy link
Collaborator

@NickSzapiro-NOAA Please turn off the control_wrtGauss_netcdf_parallel_debug test on hercules

ufs-weather-model/tests/rt.conf

Line 156 in fb8792b

RUN | control_wrtGauss_netcdf_parallel_debug | - noaacloud | baseline |

@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. New Baselines New baselines will be added to project. labels Dec 11, 2023
@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Dec 11, 2023
@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@jkbk2004 jkbk2004 merged commit 766ae99 into ufs-community:develop Dec 13, 2023
@grantfirl grantfirl mentioned this pull request Mar 11, 2024
Merged
@NickSzapiro-NOAA NickSzapiro-NOAA deleted the cpld_s2sa_p8 branch May 16, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@DeniseWorthen DeniseWorthen DeniseWorthen left review comments

@junwang-noaa junwang-noaa junwang-noaa left review comments

@SadeghTabas-NOAA SadeghTabas-NOAA Awaiting requested review from SadeghTabas-NOAA

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

Assignees
No one assigned
Labels
jenkins-ci Jenkins CI: ORT build/test on docker container New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add S2SA RT test
8 participants
@NickSzapiro-NOAA @DeniseWorthen @epic-cicd-jenkins @junwang-noaa @jkbk2004 @FernandoAndrade-NOAA @zach1221 @BrianCurtis-NOAA