Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: stepper #2305

Merged
merged 1 commit into from
Jan 10, 2023
Merged

hotfix: stepper #2305

merged 1 commit into from
Jan 10, 2023

Conversation

shenyih0ng
Copy link
Member

@shenyih0ng shenyih0ng commented Jan 10, 2023

Description

This is a hotfix for the stepper after #2304.

The issue lies in how the stepper and REPL output uses the same workspace output state (WorkspaceState["output"]). Therefore, we cannot stringify all outputs as the stepper UI relies on a array of steps.

There will be a future PR (#2306) to address this issue properly with a separation of state between the output of REPL, stepper and other debuggers

@shenyih0ng shenyih0ng self-assigned this Jan 10, 2023
@shenyih0ng shenyih0ng marked this pull request as ready for review January 10, 2023 10:26
@coveralls
Copy link

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 3882390779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 34.443%

Totals Coverage Status
Change from base Build 3870218754: 0.006%
Covered Lines: 4582
Relevant Lines: 12377

💛 - Coveralls

@martin-henz martin-henz merged commit 8e816e8 into master Jan 10, 2023
@shenyih0ng shenyih0ng deleted the hotfix/stepper branch January 10, 2023 10:57
chownces pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Jan 10, 2023
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Jul 15, 2023
@RichDom2185 RichDom2185 mentioned this pull request Aug 8, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants