Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix REPL representation bug" #2304

Closed
wants to merge 1 commit into from

Conversation

chownces
Copy link
Contributor

Reverts #2262

This PR introduced a bug in the stepper, let's revert this commit first and reopen the issue. Perhaps the next stepper team can take a look at that.

@chownces chownces requested a review from shenyih0ng January 10, 2023 09:58
@coveralls
Copy link

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 3882196655

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 16 (56.25%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 34.454%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/repl/Repl.tsx 4 5 80.0%
src/commons/sideContent/SideContentTestcaseCard.tsx 4 5 80.0%
src/commons/sideContent/githubAssessments/SideContentEditableTestcaseCard.tsx 1 6 16.67%
Totals Coverage Status
Change from base Build 3870218754: 0.02%
Covered Lines: 4589
Relevant Lines: 12390

💛 - Coveralls

@chownces
Copy link
Contributor Author

Closing in favor of #2305

@chownces chownces closed this Jan 10, 2023
@chownces chownces deleted the revert-2262-bug/repl-representation branch January 10, 2023 10:26
@shenyih0ng shenyih0ng mentioned this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants