-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore some stories tabs #2614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done for Source 2 and above. Also replaced magic number and reduced code duplication.
Also reduced code duplication.
Pull Request Test Coverage Report for Build 5794827385
💛 - Coveralls |
martin-henz
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
RichDom2185
added a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 8, 2023
* Restore data visualizer tab Done for Source 2 and above. Also replaced magic number and reduced code duplication. * Restore stepper tab Also reduced code duplication. * Restore HTML display tab * Fix toggle using stepper not being dispatched * Fix stepper not running * Fix magic number
RichDom2185
added a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 15, 2023
* Restore data visualizer tab Done for Source 2 and above. Also replaced magic number and reduced code duplication. * Restore stepper tab Also reduced code duplication. * Restore HTML display tab * Fix toggle using stepper not being dispatched * Fix stepper not running * Fix magic number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are still some bugs remaining, but nothing too major:
Type of change
Checklist