Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ID queues full bandwidth feature through parameter. #33

Merged
merged 2 commits into from
May 8, 2024
Merged

Enable ID queues full bandwidth feature through parameter. #33

merged 2 commits into from
May 8, 2024

Conversation

yvantor
Copy link

@yvantor yvantor commented Apr 17, 2024

No description provided.

@yvantor yvantor requested a review from SamuelRiedel April 17, 2024 07:34
@yvantor yvantor mentioned this pull request Apr 18, 2024
Open
@yvantor yvantor force-pushed the astral branch 2 times, most recently from 019a092 to 6a85f44 Compare April 19, 2024 20:09
SamuelRiedel
SamuelRiedel requested changes Apr 30, 2024
View reviewed changes
Copy link
Member

@SamuelRiedel SamuelRiedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Generally, it looks good to me, but could you change the default to 1 to not change the default for other designs?

@yvantor
Copy link
Author

yvantor commented May 8, 2024

Thanks. Generally, it looks good to me, but could you change the default to 1 to not change the default for other designs?

Should be done, thank you!

SamuelRiedel
SamuelRiedel requested changes May 8, 2024
View reviewed changes
src/axi_riscv_atomics_structs.sv Outdated Show resolved Hide resolved
@SamuelRiedel SamuelRiedel merged commit 27ac70f into master May 8, 2024
2 checks passed
@SamuelRiedel SamuelRiedel deleted the astral branch May 8, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelRiedel SamuelRiedel SamuelRiedel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvantor @SamuelRiedel