-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all tests with double translation too #1821
Open
OlivierNicole
wants to merge
8
commits into
ocsigen:master
Choose a base branch
from
OlivierNicole:more-tests-double-translation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Run all tests with double translation too #1821
OlivierNicole
wants to merge
8
commits into
ocsigen:master
from
OlivierNicole:more-tests-double-translation
+29
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
reviewed
Jan 28, 2025
vouillon
reviewed
Jan 28, 2025
Co-authored-by: Jérôme Vouillon <[email protected]>
vouillon
force-pushed
the
more-tests-double-translation
branch
4 times, most recently
from
January 29, 2025 14:46
beaea9a
to
4bfe5b9
Compare
vouillon
force-pushed
the
more-tests-double-translation
branch
from
January 29, 2025 15:51
73fa4f8
to
e9e9feb
Compare
@vouillon It looks like you have erased some of my commits when force-pushing. I’ll re-add them on top when the CI has finished. |
vouillon
reviewed
Jan 29, 2025
vouillon
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires some care to avoid Dune setting the flag
--effects=
twice.