Double translation: callback fixes #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a hack in caml_call_gen functions to make Js.wrap_callback work even when the OCaml function is called with more arguments that it expects. This hack was missing in the double translation case.
|
Maybe we should deprecate |
|
See #1821. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a hack in caml_call_gen functions to make Js.wrap_callback work even when the OCaml function is called with more arguments that it expects. This hack was missing in the double translation case.
Also, fix function arity computation for
Js.Unsafe.meth_callbackandJs.Unsafe.callback.We should probably run the whole test suite with
--enable double-translation, not just the effect tests. (I have run it manually.)