Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests with double translation too #1821

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,10 @@ jobs:
- run: opam exec -- make tests
if: ${{ !matrix.skip-test }}

- run: opam exec -- dune build @all @runtest @runtest-js --profile with-effects
- run: |
opam exec -- dune build @all @runtest @runtest-js --profile with-effects
OlivierNicole marked this conversation as resolved.
Show resolved Hide resolved
opam exec -- dune clean
OlivierNicole marked this conversation as resolved.
Show resolved Hide resolved
opam exec -- dune build @all @runtest @runtest-js --profile with-effects-double-translation
if: ${{ !matrix.skip-effects }}

- run: opam exec -- git diff --exit-code
Expand Down
9 changes: 9 additions & 0 deletions compiler/tests-jsoo/lib-effects-2/dune
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
(env
(with-effects-double-translation
(flags
(:standard -w -38))
(js_of_ocaml
;; separate compilation doesn't yet work when using
;; '--effect=double-translation' since Dune doesn't know it should compile a
;; different version of the dependencies.
;; TODO: remove once support in ocaml/dune#11222 is released.
(compilation_mode whole_program)))
OlivierNicole marked this conversation as resolved.
Show resolved Hide resolved
(_
(flags
(:standard -w -38))
Expand Down
9 changes: 9 additions & 0 deletions compiler/tests-ocaml/effects-2/dune
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@
;; different version of the dependencies.
;; TODO: remove once support in ocaml/dune#11222 is released.
(compilation_mode whole_program)))
(with-effects-double-translation
(flags
(:standard -w -38))
(js_of_ocaml
;; separate compilation doesn't yet work when using
;; '--effect=double-translation' since Dune doesn't know it should compile a
;; different version of the dependencies.
;; TODO: remove once support in ocaml/dune#11222 is released.
(compilation_mode whole_program)))
(_
(flags
(:standard -w -38))
Expand Down
16 changes: 16 additions & 0 deletions dune
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,22 @@
(binaries
(tools/node_wrapper.exe as node)
(tools/node_wrapper.exe as node.exe)))
(with-effects-double-translation
(js_of_ocaml
(compilation_mode separate)
(flags
(:standard --enable effects --effects double-translation))
(build_runtime_flags
(:standard --enable effects --effects double-translation)))
(wasm_of_ocaml
(compilation_mode separate)
(flags
(:standard --enable effects))
(build_runtime_flags
(:standard --enable effects)))
(binaries
(tools/node_wrapper.exe as node)
(tools/node_wrapper.exe as node.exe)))
(bench_no_debug
(flags
(:standard \ -g))
Expand Down
Loading