Food Quality System (Goblin)

[ErhardSteinhauer]

About the PR

New food quality system for species to enjoy (or suffer). Right now the only species affected by the new system are goblins. Food quality is divided into the following categories:

• High. Consuming high-quality food grants you minor bonuses, like health regeneration, but slightly more than normal food.
• Normal. Consuming high-quality food grants minor bonuses, like health regeneration.
• Low. Just satiates your hunger.
• Nasty. Consuming nasty quality food causes slight poisoning.
• Toxin. Consuming nasty quality food causes severe poisoning.

With goblins, it's the other way around: what other species consider high-quality food is viewed by goblins as toxic, so if a goblin consumes a super bite burger, goblin will severely poison himself. However, anything that other species consider toxic (space shrooms or fly amanita for example) or nasty (like raw meat and body parts) is beneficial for goblins. Additionally, goblins can eat trash like food wrappers, candles, cardboard boxes, etc (but those don't hold too much nutritious value).

Additional food categories for future use:

• Junk.
• Mail.
• Fiber.

Why / Balance

Adds more nuances to the game's food system, and lays the foundation for unique species diets (so eventually moth-persons will be able to feed upon clothes once again).

Technical details

• Cooked food is good.
• Junk food is bad.
• Some food stuffs are in between: not exactly bad, but not good either.

Media

• This PR does not require an ingame showcase.

Breaking changes

WIP.

Changelog
🆑 dvir01

• add: Added robust food quality system. Only goblins are affected by it right now, so be careful what you eat if you're a goblin: majority of cooked meals is bad for goblins (except stuff made from xeno/spider/rat meat), raw meats/organs, fly amanita, space shrooms, rotten/moldy foods, snack wrappers, carboard boxes, mail envelopes, egg shells and such are good for goblins.
• tweak: Moff food is working again for moffs.
• tweak: Only moff and goblins can eat papers.

[dvir001]

Here we go, time to move it all.

[dvir001]

Missing mail eating for Clarrpy / moth (Only opened one for moth)
Missing "Fiber" for moth food.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[whatston3]

Code review looks good. Testing as a goblin's pretty funny - curious to see goblin clowns try and escape a chase by eating fistfuls of trash. The immediate stimulants into the bloodstream seems a bit odd to me, but it works to good effect.

I've got a few suggested changes, I collected them all up on a branch on my own repo if you'd like to easily test or integrate them in one go: whatston3@4be5bd1 (toxin list additions here: whatston3@1d856d9)

[whatston3]

As with suggestion above, replace entity.Comp.FinalQuality with a local variable. It is only used within this function and does not need to live longer. Suggestion uses string as enumeration isn't used at time of writing.

Suggested change

	var foodQuality = entity.Comp.Quality;
	var foodQuality = entity.Comp.Quality;
	var finalFoodQuality = "Junk";

If accepting this, replace all entity.Comp.FinalQuality entries with finalFoodQuality or whatever local variable name you choose.

[whatston3]

FinalQuality should be removed as a field in favour of a local variable inside FoodSystem.OnDoAfter - it is not used outside of that function.

Suggested change

	/// <summary>
	/// Frontier - Edited by the system to find the final quility results
	/// </summary>
	[DataField, ViewVariables] // Frontier
	public string FinalQuality = "Normal";

[whatston3]

Move to a static readonly field in the class?

[whatston3]

Can component.Quality be used directly in the foreach?

[whatston3]

This can be made slightly more compact.
Written out as whole:

            foreach (var quality in foodQuality)
            {
                if (digestionMap.ContainsKey(quality))
                {
                    // Set foodQualityBlock based on the specific digestion capability
                    foodQualityBlock = !digestionMap[quality];
                    // If the component can digest any quality in the food, we're done.
                    if (!foodQualityBlock)
                        break;
                }
            }
            if (foodQualityBlock)
                return false;
            // End Frontier - Food System

Suggested change

	foreach (var quality in foodQuality)
	{
	if (digestionMap.ContainsKey(quality))
	{
	// Set foodQualityBlock based on whether the specific digestion capability is true
	// If the component can digest this type of quality, set to false and break out of the loop
	if (digestionMap[quality])
	{
	foodQualityBlock = false;
	break;
	}
	else
	{
	// If the component cannot digest this quality, set to true
	foodQualityBlock = true;
	}
	}
	}
	if (foodQualityBlock)
	return false;
	// Frontier - Food System
	foreach (var quality in foodQuality)
	{
	if (digestionMap.ContainsKey(quality))
	{
	// Set foodQualityBlock based on the specific digestion capability
	foodQualityBlock = !digestionMap[quality];
	// If the component can digest any quality in the food, we're done.
	if (!foodQualityBlock)
	break;
	}
	}
	if (foodQualityBlock)
	return false;
	// End Frontier - Food System

[whatston3]

Replace with const versions? Recommendation: refactor Regent->Reagent.

Suggested change

	var speedRegent = "Stimulants";
	var damagingRegent = "Toxin";
	var emoteId = "Laugh";
	const string speedRegent = "Stimulants";
	const string damagingRegent = "Toxin";
	const string emoteId = "Laugh";

[whatston3]

Suggestions:

• move toxin list to a static readonly field in the class.
• Rename to ToxinReagents (or toxinReagents if local)
• Add Gastrotoxin and Bungotoxin, for rotten meat and bungo pits.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[dvir001]

This is getting reopen in new PR