Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Food Quality System (Goblin) #1159
Food Quality System (Goblin) #1159
Changes from 39 commits
3ced7d0
a147065
199e72b
d9862db
79f80e2
2fca643
142b1a3
443322c
03ce1a6
d7f6d41
0c82113
a93646a
06c29ad
85538a2
c4e7c52
730522f
38f3a33
075435b
611be4a
ba68a1b
802d6f1
3fafed3
a41995a
9693762
fe792f7
2ff271a
bd84268
a3cf959
24c27e8
d009322
f890786
94294be
e9a96a6
0b59814
39aefbd
0d099ee
0d15fce
052d619
118699e
ac5ed9a
b68dbc3
4986a68
43c326c
e170050
69e9585
86e939a
a411773
4874a83
eaee2bf
7298cf6
7a6338e
6c7010f
483d048
311260b
92dd46b
4130c94
bf200cb
9aebf22
38f6b4e
5773635
5b5852e
743d8f2
cbc57d7
27f449a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with suggestion above, replace entity.Comp.FinalQuality with a local variable. It is only used within this function and does not need to live longer. Suggestion uses string as enumeration isn't used at time of writing.
If accepting this, replace all
entity.Comp.FinalQuality
entries withfinalFoodQuality
or whatever local variable name you choose.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace with const versions? Recommendation: refactor Regent->Reagent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make this a lot cleaner if you just put the number in the quality enum like so;
and then just split it up into a function or so if it is not reversed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can component.Quality be used directly in the foreach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be godly if you can turn this into something like:
you'd have to turn it into a prototype and it will be cleaner