Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust solution size on slicing/eating food #1644

Merged

Conversation

whatston3
Copy link
Contributor

About the PR

When food is bitten or sliced, this adjusts the capacity in the food - for instance, you shouldn't be able to replace the bite of chocolate cake you just ate with ketchup.

Why / Balance

Separated out at the request of @dvir001 - this was added into the Goblin Food Rework PR (#1159) a long time ago, and has been stuck in limbo and needs more work. Feature's simple enough and easy to verify that it should be done separately.

How to test

  1. Spawn an apple.
  2. Open the solution editor on the apple.
  3. Take a bite. Note that the solution capacity decreases.
  4. Spawn an apple cake and a knife.
  5. Cut the cake. Note that the solution capacity decreases proportionally with the number of slices in the cake.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑 erhardsteinhauer

  • tweak: Food now loses capacity when bitten or sliced.

@github-actions github-actions bot added the C# label Jul 10, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jul 10, 2024

Mfw changelog

@dvir001 dvir001 self-requested a review July 10, 2024 20:39
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jul 10, 2024
@dvir001 dvir001 merged commit 8113134 into new-frontiers-14:master Jul 10, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Jul 10, 2024
@whatston3 whatston3 deleted the 2024-07-10-food-capacity-adjustment branch July 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants