Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edr/video bugs #69

Merged
merged 19 commits into from
Mar 25, 2024
Merged

Edr/video bugs #69

merged 19 commits into from
Mar 25, 2024

Conversation

evanderiel
Copy link
Collaborator

@evanderiel evanderiel commented Feb 29, 2024

Fix bug relating video and media tables in database
Set duration when saving videos

Copy link
Contributor

@movchan74 movchan74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes to delete_media function. Does cascade deletion work now? It is a part of the issue #46.

aana/configs/pipeline.py Show resolved Hide resolved
aana/utils/db.py Show resolved Hide resolved
aana/models/db/video.py Outdated Show resolved Hide resolved
@evanderiel evanderiel requested a review from movchan74 March 15, 2024 10:22
Copy link
Contributor

@movchan74 movchan74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see any changes to delete_media function. Does cascade deletion work now?

aana/tests/integration/test_chat_with_video.py Outdated Show resolved Hide resolved
aana/utils/db.py Outdated Show resolved Hide resolved
aana/utils/db.py Outdated Show resolved Hide resolved
aana/models/db/video.py Outdated Show resolved Hide resolved
# Conflicts:
#	aana/configs/deployments.py
#	aana/configs/pipeline.py
#	aana/tests/integration/test_chat_with_video.py
#	aana/utils/db.py
@evanderiel evanderiel requested a review from movchan74 March 21, 2024 11:33
@evanderiel evanderiel merged commit 93bcf3a into main Mar 25, 2024
2 checks passed
@evanderiel evanderiel deleted the edr/video_bugs branch May 21, 2024 08:45
movchan74 pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] video_id in Media Entities is always None [ENHANCEMENT] Add duration to video metadata
2 participants