Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] video_id in Media Entities is always None #46

Closed
movchan74 opened this issue Feb 9, 2024 · 0 comments · Fixed by #69
Closed

[BUG] video_id in Media Entities is always None #46

movchan74 opened this issue Feb 9, 2024 · 0 comments · Fixed by #69
Assignees
Labels
bug Something isn't working wip Work In Progress

Comments

@movchan74
Copy link
Contributor

Bug Description

  • The video_id attribute in the media entity is not being properly set during the media creation process. As a result, when attempting to save a video, the video_id field remains None, which leads to complications in implementing cascade deletion features.

Steps to Reproduce

  1. Index the video with "chat_with_video" target.
  2. Observe that the video_id within the saved media entity remains None.

Expected Behavior

  • The video_id within a media entity should be correctly set and saved, reflecting the associated video's identifier. This setup should facilitate the implementation of cascade deletion, allowing for the automatic deletion of associated videos when a media entity is deleted.

Actual Behavior

  • The video_id remains None after saving the media entity, regardless of the video association. Due to this, cascade deletion cannot be implemented as intended. Consequently, to delete a media entity and its associated video (see delete_media function), separate delete calls must be made for both the media entity and the video entity, complicating the deletion process.

Environment

@movchan74 movchan74 added the bug Something isn't working label Feb 9, 2024
@movchan74 movchan74 added the wip Work In Progress label Feb 13, 2024
@evanderiel evanderiel linked a pull request Mar 1, 2024 that will close this issue
@movchan74 movchan74 mentioned this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wip Work In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants