Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add duration to video metadata #25

Closed
evanderiel opened this issue Dec 14, 2023 · 2 comments · Fixed by #69
Closed

[ENHANCEMENT] Add duration to video metadata #25

evanderiel opened this issue Dec 14, 2023 · 2 comments · Fixed by #69
Assignees
Labels
enhancement New feature or request

Comments

@evanderiel
Copy link
Collaborator

Enhancement Description

  • Add duration to Video Metadata

Advantages

  • Gives us a place to retrieve video duration inside the pipeline so we can store it

Possible Implementation

  • Run ffprobe or a library that wraps the same functionality.
@evanderiel evanderiel added the enhancement New feature or request label Dec 14, 2023
@movchan74
Copy link
Contributor

@evanderiel please add title

@evanderiel evanderiel changed the title [ENHANCEMENT] [ENHANCEMENT] Add duration to video metadata Jan 22, 2024
@movchan74
Copy link
Contributor

Duration is already returned by frame extraction.

And it's already a field in the Video Entity.

So we only need to add it as input to save video function and update pipeline.

@evanderiel evanderiel linked a pull request Mar 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants