Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to tests #216

Merged
merged 14 commits into from
Dec 18, 2023
Merged

Add Python 3.12 to tests #216

merged 14 commits into from
Dec 18, 2023

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Dec 14, 2023

Description

Following up on Add Python 3.12 to tests:

In vizro-core and vizro-ai:

  • Include 3.12 in classifiers in pyproject.toml
  • Include 3.12 in our badge in the README
  • Include 3.12 in [[envs.all.matrix]]
  • Make sure the relevant 3.12 jobs are required for merging in Github branch protection settings
  • Fix any problems that make our code incompatible with 3.12 (only got one new deprecation warning coming from pandas as pandas doesn't support python 3.12 just yet - decided to ignore that particular deprecation warning for now)

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@huong-li-nguyen huong-li-nguyen linked an issue Dec 14, 2023 that may be closed by this pull request
6 tasks
@huong-li-nguyen huong-li-nguyen changed the title Dev/add python 312 Add Python 3.12 to tests Dec 14, 2023
@huong-li-nguyen huong-li-nguyen self-assigned this Dec 14, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review December 14, 2023 17:10
@antonymilne
Copy link
Contributor

Note in case we need to use the environment all.py3.12 locally some time... Here's how I did it:

  1. brew install [email protected]
  2. Trying to do anything with the hatch all.py3.12 environment fails with this error
  3. Hatch uses virtualenv for its environments, but it's not possible to do any hatch commands in the environment to fix it because as soon as you activate all.py3.12 it starts running pip, which is the cause of the failure. Hence to fix you need to find the environment (hatch env find) and then source activate to manually activate the virtualenv
  4. After that doing python -m ensurepip --upgrade fixed the pip version for me, but maybe you'd also need to do some of the other commands there to clear the virtualenv cache

I also did pipx upgrade hatch but not sure if it's necessary.

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving subject to some resolution on the open conversation, even if that resolution is that we should give up 😀

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I didn't follow the thread in detail. Would update the changelog though

@huong-li-nguyen huong-li-nguyen merged commit fa7c45d into main Dec 18, 2023
38 checks passed
@huong-li-nguyen huong-li-nguyen deleted the dev/add_python_312 branch December 18, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.12 to tests
3 participants