Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.12 to tests #193

Closed
5 of 6 tasks
antonymilne opened this issue Dec 6, 2023 · 0 comments · Fixed by #216
Closed
5 of 6 tasks

Add Python 3.12 to tests #193

antonymilne opened this issue Dec 6, 2023 · 0 comments · Fixed by #216
Assignees
@huong-li-nguyen

Comments

@antonymilne
Copy link
Contributor

antonymilne commented Dec 6, 2023 •
edited by huong-li-nguyen
Loading

Quick and easy - do for both vizro-core and vizro-ai:

  • In our matrix on Github actions, we currently test on python-version up to and including 3.11. Let's add 3.12 to the list
  • Include 3.12 in classifiers in pyproject.toml
  • Include 3.12 in our badge in the README
  • Include 3.12 in [[envs.all.matrix]]
  • Make sure the relevant 3.12 jobs are required for merging in Github branch protection settings

Could be difficult but I don't expect it will be necessary, at least for vizro-core:

  • Fix any problems that make our code incompatible with 3.12
@huong-li-nguyen huong-li-nguyen self-assigned this Dec 14, 2023
@huong-li-nguyen huong-li-nguyen linked a pull request Dec 14, 2023 that will close this issue
Add Python 3.12 to tests #216
Merged
14 tasks
@huong-li-nguyen huong-li-nguyen mentioned this issue Dec 14, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huong-li-nguyen huong-li-nguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Python 3.12 to tests mckinsey/vizro
2 participants
@antonymilne @huong-li-nguyen