Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to tests #216

Merged
merged 14 commits into from
Dec 18, 2023
Merged

Add Python 3.12 to tests #216

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e5b249a
Add python 3.12 in relevant places
huong-li-nguyen Dec 14, 2023
c307a77
Ignore deprecation warning on utcfromtimestamp
huong-li-nguyen Dec 14, 2023
b5a6a45
Fix issues in vizro-ai
huong-li-nguyen Dec 14, 2023
a1b5b88
Try to ignore Kedro error message
antonymilne Dec 15, 2023
9c318ca
Oops
antonymilne Dec 15, 2023
e99f980
Double oops
antonymilne Dec 15, 2023
ddfb21f
Triple oops
antonymilne Dec 15, 2023
962e4ea
Quadruple oops
antonymilne Dec 15, 2023
933dd44
Lint
huong-li-nguyen Dec 15, 2023
9465df8
Merge branch 'main' into dev/add_python_312
huong-li-nguyen Dec 15, 2023
a347573
PR comments
huong-li-nguyen Dec 15, 2023
58eb180
Remove quotation marks
huong-li-nguyen Dec 18, 2023
b4b6c5a
Revert changes and edit changelog
huong-li-nguyen Dec 18, 2023
f2ccef1
PR comments
huong-li-nguyen Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test-integration-vizro-ai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ jobs:
hatch-env: all.py3.10
- python-version: "3.11"
hatch-env: all.py3.11
- python-version: "3.11"
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
hatch-env: lower-bounds
label: lower bounds

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-integration-vizro-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ jobs:
hatch-env: all.py3.10
- python-version: "3.11"
hatch-env: all.py3.11
- python-version: "3.11"
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
hatch-env: lower-bounds
label: lower bounds

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-unit-vizro-ai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ jobs:
hatch-env: all.py3.10
- python-version: "3.11"
hatch-env: all.py3.11
- python-version: "3.11"
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
hatch-env: lower-bounds
label: lower bounds

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-unit-vizro-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ jobs:
hatch-env: all.py3.10
- python-version: "3.11"
hatch-env: all.py3.11
- python-version: "3.11"
- python-version: "3.12"
hatch-env: all.py3.12
- python-version: "3.12"
hatch-env: lower-bounds
label: lower bounds

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<div align="center" markdown="1">

[![Python version](https://img.shields.io/badge/python-3.8%20%7C%203.9%20%7C%203.10%20%7C%203.11-blue.svg)](https://pypi.org/project/vizro/)
[![Python version](https://img.shields.io/badge/python-3.8%20%7C%203.9%20%7C%203.10%20%7C%203.11%20%7C%203.12-blue.svg)](https://pypi.org/project/vizro/)
[![PyPI version](https://badge.fury.io/py/vizro.svg)](https://badge.fury.io/py/vizro)
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/mckinsey/vizro/blob/main/LICENSE.md)
[![Documentation](https://readthedocs.org/projects/vizro/badge/?version=stable)](https://vizro.readthedocs.io/)
Expand Down
4 changes: 3 additions & 1 deletion vizro-ai/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Vizro-AI README
# Vizro-AI

[![Python version](https://img.shields.io/badge/python-3.9%20%7C%203.10%20%7C%203.11%20%7C%203.12-blue.svg)](https://pypi.org/project/vizro/)

Vizro-AI is a tool for generating visualizations.

Expand Down
48 changes: 48 additions & 0 deletions vizro-ai/changelog.d/20231214_163129_huong_li_nguyen_add_python_312.md
View file
Open in desktop
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨

- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Removed

- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Added

- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Changed

- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Deprecated

- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Fixed

- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Security

- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
2 changes: 1 addition & 1 deletion vizro-ai/hatch.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[envs.all]

[[envs.all.matrix]]
python = ["3.9", "3.10", "3.11"]
python = ["3.9", "3.10", "3.11", "3.12"]

[envs.changelog]
dependencies = ["scriv"]
Expand Down
9 changes: 7 additions & 2 deletions vizro-ai/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ classifiers = [
"Programming Language :: Python",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11"
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12"
]
dependencies = [
"pandas",
Expand Down Expand Up @@ -48,4 +49,8 @@ parallel = true
source_pkgs = ["vizro_ai"]

[tool.pytest.ini_options]
filterwarnings = "error"
filterwarnings = [
"error",
# Ignore this warning here as it comes from pandas until pandas is made compatible with Python 3.12
'ignore:.*utcfromtimestamp.*:DeprecationWarning'
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
]
2 changes: 1 addition & 1 deletion vizro-core/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

<div align="center" markdown="1">

[![Python version](https://img.shields.io/badge/python-3.8%20%7C%203.9%20%7C%203.10%20%7C%203.11-blue.svg)](https://pypi.org/project/vizro/)
[![Python version](https://img.shields.io/badge/python-3.8%20%7C%203.9%20%7C%203.10%20%7C%203.11%20%7C%203.12-blue.svg)](https://pypi.org/project/vizro/)
[![PyPI version](https://badge.fury.io/py/vizro.svg)](https://badge.fury.io/py/vizro)
[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/mckinsey/vizro/blob/main/LICENSE.md)
[![Documentation](https://readthedocs.org/projects/vizro/badge/?version=stable)](https://vizro.readthedocs.io/)
Expand Down
48 changes: 48 additions & 0 deletions vizro-core/changelog.d/20231214_163119_huong_li_nguyen_add_python_312.md
View file
Open in desktop
huong-li-nguyen marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
-->

<!--
### Highlights ✨

- A bullet item for the Highlights ✨ category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Removed

- A bullet item for the Removed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Added

- A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Changed

- A bullet item for the Changed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Deprecated

- A bullet item for the Deprecated category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Fixed

- A bullet item for the Fixed category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
<!--
### Security

- A bullet item for the Security category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))

-->
13 changes: 8 additions & 5 deletions vizro-core/hatch.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
[envs.all]
features = ["kedro"]

[[envs.all.matrix]]
python = ["3.8", "3.9", "3.10", "3.11"]
python = ["3.8", "3.9", "3.10", "3.11", "3.12"]

[envs.all.overrides]
matrix.python.features = [
{value = "kedro", if = ["3.8", "3.9", "3.10"]}
]
[envs."all.py3.12".env-vars]
# Kedro converts warning "not yet fully compatible with this Python version" into an
# exception, so it can't be filtered out by pytest's filterwarnings. Instead we need
# to modify sys.warnoptions upfront so that Kedro does not convert the warning to an
# exception.
PYTHONWARNINGS = "ignore:Kedro is not yet fully compatible"

[envs.changelog]
dependencies = ["scriv"]
Expand Down
9 changes: 7 additions & 2 deletions vizro-core/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ classifiers = [
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11"
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12"
]
dependencies = [
"dash>=2.14.1", # 2.14.1 needed for compatibility with werkzeug
Expand Down Expand Up @@ -71,6 +72,10 @@ addopts = [
# Allow test files to have the same name in different directories.
"--import-mode=importlib"
]
filterwarnings = "error"
filterwarnings = [
"error",
# Ignore this warning here as it comes from pandas until pandas is made compatible with Python 3.12
"ignore:.*utcfromtimestamp:DeprecationWarning"
]
norecursedirs = ["tests/tests_utils", "tests/js"]
pythonpath = ["tests/tests_utils"]
7 changes: 2 additions & 5 deletions vizro-core/tests/unit/vizro/integrations/kedro/test_kedro_data_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,9 @@

import pytest
import yaml
from kedro.io import DataCatalog

kedro = pytest.importorskip("kedro")

from kedro.io import DataCatalog # noqa: E402

from vizro.integrations.kedro import datasets_from_catalog # noqa: E402
from vizro.integrations.kedro import datasets_from_catalog


@pytest.fixture
Expand Down
Loading