Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Lottery #1703

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
for (int i = 0; i < 3; i++) {
System.out.println(Lottery.getRandomBall());
}
}
}
27 changes: 27 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package core.basesyntax;

public class Ball {
private Color color;
private int number;

public Ball(Color randomColor, int number) {
this.color = randomColor;
this.number = number;
}

public Color getColor() {
return color;
}

public int getNumber() {
return number;
}

@Override
public String toString() {
return "Ball{"
+ "color='" + getColor() + '\''
+ ", number=" + getNumber()
+ '}';
}
MaybeTI marked this conversation as resolved.
Show resolved Hide resolved
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Color.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public enum Color {
RED,
GREEN,
BLUE,
YELLOW,
ORANGE,
PURPLE,
CYAN,
MAGENTA,
BLACK,
WHITE
}
6 changes: 4 additions & 2 deletions src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
public static Color getRandomColor() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public static Color getRandomColor() {
public Color getRandomColor() {

Don't use static methods in your solution (from common mistakes)

return Color.values()[new Random().nextInt(Color.values().length)];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about which variables should be local in the method and which should be class-level (following common mistakes)

}
}
9 changes: 9 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {
public static Ball getRandomBall() {
return new Ball(ColorSupplier.getRandomColor(), new Random().nextInt(101));
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same Also, All magic numbers in your code should be constants. (from common mistakes)

}