Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Lottery #1703

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package core.basesyntax;

public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
private static final int BALL_COUNT = 3;

public void main(String[] args) {
for (int i = 0; i < BALL_COUNT; i++) {
System.out.println(new Lottery().getRandomBall());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this realization, you create 3 new instances one instant is enough

Comment on lines +6 to +8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void main(String[] args) {
for (int i = 0; i < BALL_COUNT; i++) {
System.out.println(new Lottery().getRandomBall());
public void main(String[] args) {
Lottery lottery = new Lottery();
for (int i = 0; i < BALL_COUNT; i++) {
System.out.println(lottery.getRandomBall());

}
}
}
27 changes: 27 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package core.basesyntax;

public class Ball {
private Color color;
private int number;

public Ball(Color randomColor, int number) {
this.color = randomColor;
this.number = number;
}

public Color getColor() {
return color;
}

public int getNumber() {
return number;
}

@Override
public String toString() {
return "Ball{"
+ "color='" + getColor() + '\''
+ ", number=" + getNumber()
+ '}';
}
MaybeTI marked this conversation as resolved.
Show resolved Hide resolved
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Color.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public enum Color {
RED,
GREEN,
BLUE,
YELLOW,
ORANGE,
PURPLE,
CYAN,
MAGENTA,
BLACK,
WHITE
}
8 changes: 6 additions & 2 deletions src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
private Random random = new Random();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private Random random = new Random();
private final Random random = new Random();


public Color getRandomColor() {
return Color.values()[random.nextInt(Color.values().length)];
}
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {
private static final int BALL_NUMBER = 101;
private Random random = new Random();

public Ball getRandomBall() {
return new Ball(new ColorSupplier().getRandomColor(), random.nextInt(BALL_NUMBER));
Comment on lines +7 to +10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private Random random = new Random();
public Ball getRandomBall() {
return new Ball(new ColorSupplier().getRandomColor(), random.nextInt(BALL_NUMBER));
private final Random random = new Random();
private final ColorSupplier supplier = new ColorSupplier()
public Ball getRandomBall() {
return new Ball(supplier.getRandomColor(), random.nextInt(BALL_NUMBER));

}
}
Loading