Implement Lottery #1703
Open
Implement Lottery #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/core/basesyntax/Lottery.java
liliia-ponomarenko
suggested changes
Nov 28, 2024
Comment on lines
4
to
5
| private final Colors color; | ||
| private final int number; |
There was a problem hiding this comment.
Suggested change
| private final Colors color; | |
| private final int number; | |
| private Colors color; | |
| private int number; |
| @@ -0,0 +1,14 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public enum Colors { | |||
There was a problem hiding this comment.
Suggested change
| public enum Colors { | |
| public enum Color { |
liliia-ponomarenko
suggested changes
Nov 29, 2024
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| public static Color getRandomColor() { |
There was a problem hiding this comment.
Suggested change
| public static Color getRandomColor() { | |
| public Color getRandomColor() { |
Don't use static methods in your solution (from common mistakes)
| public String getRandomColor() { | ||
| return null; | ||
| public static Color getRandomColor() { | ||
| return Color.values()[new Random().nextInt(Color.values().length)]; |
There was a problem hiding this comment.
Think about which variables should be local in the method and which should be class-level (following common mistakes)
Comment on lines
6
to
8
| public static Ball getRandomBall() { | ||
| return new Ball(ColorSupplier.getRandomColor(), new Random().nextInt(101)); | ||
| } |
There was a problem hiding this comment.
the same Also, All magic numbers in your code should be constants. (from common mistakes)
liliia-ponomarenko
approved these changes
Dec 4, 2024
|
|
||
| public void main(String[] args) { | ||
| for (int i = 0; i < BALL_COUNT; i++) { | ||
| System.out.println(new Lottery().getRandomBall()); |
There was a problem hiding this comment.
in this realization, you create 3 new instances one instant is enough
Comment on lines
+6
to
+8
| public void main(String[] args) { | ||
| for (int i = 0; i < BALL_COUNT; i++) { | ||
| System.out.println(new Lottery().getRandomBall()); |
There was a problem hiding this comment.
Suggested change
| public void main(String[] args) { | |
| for (int i = 0; i < BALL_COUNT; i++) { | |
| System.out.println(new Lottery().getRandomBall()); | |
| public void main(String[] args) { | |
| Lottery lottery = new Lottery(); | |
| for (int i = 0; i < BALL_COUNT; i++) { | |
| System.out.println(lottery.getRandomBall()); |
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| private Random random = new Random(); |
There was a problem hiding this comment.
Suggested change
| private Random random = new Random(); | |
| private final Random random = new Random(); |
Comment on lines
+7
to
+10
| private Random random = new Random(); | ||
|
|
||
| public Ball getRandomBall() { | ||
| return new Ball(new ColorSupplier().getRandomColor(), random.nextInt(BALL_NUMBER)); |
There was a problem hiding this comment.
Suggested change
| private Random random = new Random(); | |
| public Ball getRandomBall() { | |
| return new Ball(new ColorSupplier().getRandomColor(), random.nextInt(BALL_NUMBER)); | |
| private final Random random = new Random(); | |
| private final ColorSupplier supplier = new ColorSupplier() | |
| public Ball getRandomBall() { | |
| return new Ball(supplier.getRandomColor(), random.nextInt(BALL_NUMBER)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.