KOGITO-4343: Fix JSONIX model generation with gwt 2.9 #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treblereel
requested review from
karreiro,
tiagodolphine and
yesamer
and removed request for
karreiro
|
@treblereel What is the difference with this PR? #3570 |
This was referenced Mar 8, 2021
Closed
yesamer
approved these changes
Mar 17, 2021
yesamer
reviewed
Mar 17, 2021
| @@ -125,7 +125,7 @@ public void checkAttachDomElement() { | |||
| domElementOnDisplay); | |||
| } | |||
|
|
|||
| @Test | |||
| //@Test | |||
There was a problem hiding this comment.
@treblereel Why is this test ignored?
karreiro
reviewed
Mar 29, 2021
There was a problem hiding this comment.
Thank you, @treblereel. The PR looks great! 🚀 Can we uncomment the test that @yesamer mentioned? :-)
|
wrong branch has been pushed ... let me fix it |
|
Kudos, SonarCloud Quality Gate passed! |
|
java.io.IOException: No space left on device :( |
karreiro
approved these changes
Mar 30, 2021
jomarko
reviewed
Mar 30, 2021
Comment on lines
-281
to
-340
| @Test | ||
| public void testConnect() { | ||
| final DMNMarshaller dmnMarshaller = new DMNMarshaller(); | ||
| final JSIDMNDiagram diagram = mock(JSIDMNDiagram.class); | ||
| final List<String> dmnDiagramElementIds = mock(List.class); | ||
| final Definitions definitionsStunnerPojo = mock(Definitions.class); | ||
| final List<JSIDMNEdge> dmnEdges = new ArrayList<>(); | ||
|
|
||
| final Node<?, ?> node = mock(Node.class); | ||
| final List inEdges = new ArrayList<>(); | ||
| final Edge edge = mock(Edge.class); | ||
| final Node sourceNode = mock(Node.class); | ||
| final View sourceView = mock(View.class); | ||
| final ViewConnector viewConnector = mock(ViewConnector.class); | ||
| final DiscreteConnection sourceConnection = mock(DiscreteConnection.class); | ||
| final DiscreteConnection targetConnection = mock(DiscreteConnection.class); | ||
| final View<?> view = mock(View.class); | ||
|
|
||
| inEdges.add(edge); | ||
| when(edge.getSourceNode()).thenReturn(sourceNode); | ||
| when(sourceNode.getContent()).thenReturn(sourceView); | ||
|
|
||
| when(node.getInEdges()).thenReturn(inEdges); | ||
| when(edge.getContent()).thenReturn(viewConnector); | ||
| when(viewConnector.getControlPoints()).thenReturn(new ControlPoint[]{}); | ||
| when(sourceConnection.isAuto()).thenReturn(true); | ||
| when(targetConnection.isAuto()).thenReturn(true); | ||
| when(diagram.getName()).thenReturn("dmnEdge"); | ||
| when(definitionsStunnerPojo.getDefaultNamespace()).thenReturn("org.edge"); | ||
|
|
||
| when(viewConnector.getSourceConnection()).thenReturn(Optional.of(sourceConnection)); | ||
| when(viewConnector.getTargetConnection()).thenReturn(Optional.of(targetConnection)); | ||
| dmnMarshaller.connect(diagram, | ||
| dmnDiagramElementIds, | ||
| definitionsStunnerPojo, | ||
| dmnEdges, | ||
| node, | ||
| view); | ||
|
|
||
| when(viewConnector.getSourceConnection()).thenReturn(Optional.empty()); | ||
| when(viewConnector.getTargetConnection()).thenReturn(Optional.empty()); | ||
| dmnMarshaller.connect(diagram, | ||
| dmnDiagramElementIds, | ||
| definitionsStunnerPojo, | ||
| dmnEdges, | ||
| node, | ||
| view); | ||
|
|
||
| when(viewConnector.getSourceConnection()).thenReturn(Optional.of(sourceConnection)); | ||
| when(viewConnector.getTargetConnection()).thenReturn(Optional.empty()); | ||
| dmnMarshaller.connect(diagram, | ||
| dmnDiagramElementIds, | ||
| definitionsStunnerPojo, | ||
| dmnEdges, | ||
| node, | ||
| view); | ||
|
|
||
| verify(sourceConnection).isAuto(); | ||
| verify(targetConnection).isAuto(); | ||
| } |
There was a problem hiding this comment.
Why we need to remove this test please?
|
No resources to review this anymore. Please proceed without my further review. |
|
@karreiro @treblereel I think this can close, considering Kogito asserts are no more present in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/KOGITO-4343
Related PRs:
kiegroup/gwt-jsonix-schema-compiler#11
kiegroup/droolsjbpm-build-bootstrap#1606
#3570
#3562
#3582
to test localy set gwt-jsonix-schema-compiler version to 1.3.0-SNAPSHOT
@yesamer ^^