KOGITO-4343: Fix JSONIX model generation with gwt 2.9 #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@treblereel @tiagobento Should we remove properties |
yesamer
requested changes
Mar 17, 2021
There was a problem hiding this comment.
Considering my comment here: kiegroup/droolsjbpm-build-bootstrap#1606 (review)
Please use the same branch name (treelereel:KOGITO-4343) in order to link the PRs during the build.
|
@treblereel I think this can close, considering Kogito asserts are no more present in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/KOGITO-4343
related to kiegroup/gwt-jsonix-schema-compiler#11
depends on kiegroup/kie-wb-common#3582
to test localy set gwt-jsonix-schema-compiler version to 1.3.0-SNAPSHOT
@yesamer ^^