KOGITO-4343: fixed jsonix CCE with gwt290 #3570
Conversation
|
Hi @karreiro! This PR fixes the remaining issues on the development webapps. It depends on a breaking change at kiegroup/gwt-jsonix-schema-compiler#11. After this PR on JSONIX is merged, a new PR will be sent to Also note that this PR works together with #3562. In summary, after this one (#3570) and #3562 are merged, the flags disabling the new type-checks introduced in GWT 2.9 can be safely removed. |
There was a problem hiding this comment.
Thank you, @treblereel! Excellent work!
I've left only a minor comment. But I just tested it locally, I ran all IT suites, and everything works fine :-)
| @@ -125,7 +125,7 @@ public void checkAttachDomElement() { | |||
| domElementOnDisplay); | |||
| } | |||
|
|
|||
| @Test | |||
| //@Test | |||
There was a problem hiding this comment.
I believe we can uncomment this test :-) (it passes locally here)
|
Closing in favor of #3582 |
JIRA: https://issues.redhat.com/browse/KOGITO-4343
Related PRs:
kiegroup/gwt-jsonix-schema-compiler#11
kiegroup/droolsjbpm-build-bootstrap#1606
#3570
#3562
#3582
to test it locally, gwt-jsonix-schema-compiler must be install first, in kie-wb-common-dmn-webapp-kogito-marshaller/pom.xml version of gwt-jsonix-schema-compiler must setted to 1.3.0-SNAPSHOT
this issue is related to #3562