Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default values #222

Merged
merged 5 commits into from
Aug 7, 2024
Merged

add default values #222

merged 5 commits into from
Aug 7, 2024

Conversation

ocots
Copy link
Member

@ocots ocots commented Aug 7, 2024

No description provided.

@ocots ocots linked an issue Aug 7, 2024 that may be closed by this pull request
@ocots
Copy link
Member Author

ocots commented Aug 7, 2024

@jbcaillau @PierreMartinon Please review the default values.

__grid_size_direct() = 100

or

__grid_size_direct() = 200

With 200 there is a problem here: https://control-toolbox.org/OptimalControl.jl/stable/tutorial-double-integrator.html

With 100 the control is ugly: https://control-toolbox.org/OptimalControl.jl/v0.9/tutorial-double-integrator.html

@ocots
Copy link
Member Author

ocots commented Aug 7, 2024

@ocots
Copy link
Member Author

ocots commented Aug 7, 2024

I let __ocp_init but I put the others (with the docstrings) in CTDirect.jl, cf. control-toolbox/CTDirect.jl#195 (comment).

@ocots ocots marked this pull request as ready for review August 7, 2024 09:29
@ocots ocots marked this pull request as draft August 7, 2024 09:42
@ocots ocots mentioned this pull request Aug 7, 2024
4 tasks
@ocots ocots marked this pull request as ready for review August 7, 2024 19:30
@ocots ocots merged commit 1566625 into main Aug 7, 2024
3 checks passed
@ocots ocots deleted the 221-default-functions branch August 7, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default functions
2 participants