Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elastic_volumes and database_persistence logic #1899

Conversation

kosstennbl
Copy link
Collaborator

@kosstennbl kosstennbl commented Feb 16, 2024

elastic_volumes test should fail if any of the volumes is not elastic database_persistence test should test specifically resources with mysql images and pass if condition is true for all of them. This commit should fix that.
Fixes: #1884

Description

Redesigned these tests according to the discussion in the #1884.
database_persistence is tested on bitnami/mysql helm chart (i don't have possibility to set up elastic volumes, so i've checked that it fails with elastic_volume condition and passes without it)

Issues:

Refs: #1884

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

elastic_volumes test should fail if any of the volumes is not elastic
database_persistence test should test specifically resources with mysql
images and pass if condition is true for all of them.
This commit should fix that.
Fixes: cnti-testcatalog#1884

Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl
Copy link
Collaborator Author

@HashNuke if you'll have some free time for this - please check this PR.
also, I'll be offline on the next week, so i wouldn't be able to respond quickly.

@HashNuke
Copy link
Collaborator

The changes to expected messages for elastic_volumes test in specs had to be updated.

I have already made the changes in my branch that combines changes from multiple PRs (pr-1862-1893-1899-1890-1895-1869).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect logic of elastic_volumes and database_persistence tests
4 participants