Fix output for elastic and db persistence tests #1885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cnti-testcatalog#1201 Output of these tests should correctly represent what is being tested. With new messages - it is visible, that test logic is flawed and should be fixed (in another commit). Change test messages of elastic_volumes and database_persistence Change expected messages in spec tests. Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
requested review from
denverwilliams,
wvwatson and
agentpoyo
as code owners
HashNuke
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
LGTM 👍
I checked the functionality of the test. And it looks like the new output messages match the functionality.
I'll create another ticket for improving the functionality of the database persistence test over what it currently does. I made some notes based on what I found in the test.
|
I've already created an issue with some thoughts on that, #1884 |
|
@kosstennbl Thank you. Just read the ticket. I'll post some notes to help you take that forward. |
|
@collivier Could you please update this PR with the latest changes from the main branch and resolve conflicts? Merging latest main would also fix any build issues that aren't related to this PR. Thanks. |
|
Issue is fixed in #1899 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1201
Output of these tests should correctly represent what is being tested. With new messages - it is visible, that test logic is flawed and should be fixed (in another commit).
Change test messages of elastic_volumes and database_persistence Change expected messages in spec tests.
Description
Change for test message in test and spec, changed order of statements in database_persistence so it would make sense. Was successfully built.
Changes in messages show what tests really do, proposed fixes and a bit of issue analysis is there:
#1884
Issues:
Refs: #1201
How has this been tested:
Types of changes:
Checklist:
Documentation
Code Review
Issue