Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] database_persistence and elastic_volumes test have very similar success and failure messages #1201

Closed
HashNuke opened this issue Feb 3, 2022 · 2 comments
Closed

[BUG] database_persistence and elastic_volumes test have very similar success and failure messages #1201

HashNuke opened this issue Feb 3, 2022 · 2 comments
Assignees
@taylor @HashNuke @agentpoyo
Labels
bug Something isn't working

Comments

@HashNuke
Copy link
Collaborator

HashNuke commented Feb 3, 2022

Describe the bug

database_persistence and elastic_volumes test have very similar success and failure messages. When reading the testsuite output, it is hard to understand what was tested for.

Below is an example workload run with failure messages for both test outputs.

image

Messages for the database_persistence test

PASSED: Elastic Volumes Used
PASSED: Elastic Volumes and Statefulsets Used
FAILED: Elastic Volumes Not Used
FAILED: Statefulset used without an elastic volume

Messages for the elastic_volumes test

PASSED: Elastic Volumes Used
FAILED: Elastic Volumes Not Used

To Reproduce

Try running the elastic_volumes test and the database_persistence tests as a part of the workload group.

./cnf-testsuite workload

Expected behavior

Indicate what is being tested in the appropriate success/failure messages.
@HashNuke HashNuke added the bug Something isn't working label Feb 3, 2022
@HashNuke HashNuke mentioned this issue Feb 3, 2022
Closed
kosstennbl pushed a commit to kosstennbl/cnf-testsuite that referenced this issue Feb 12, 2024
Fix output for elastic and db persistence tests
8d8fe6e 
Fixes cnti-testcatalog#1201
Output of these tests should correctly represent what is being tested.
With new messages - it is visible, that test logic is flawed and
should be fixed (in another commit).
Change test messages of elastic_volumes and database_persistence
Change expected messages in spec tests.

Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl pushed a commit to kosstennbl/cnf-testsuite that referenced this issue Feb 12, 2024
Fix output for elastic and db persistence tests
6136819 
Fixes cnti-testcatalog#1201
Output of these tests should correctly represent what is being tested.
With new messages - it is visible, that test logic is flawed and
should be fixed (in another commit).
Change test messages of elastic_volumes and database_persistence
Change expected messages in spec tests.

Signed-off-by: Konstantin Yarovoy <[email protected]>
@kosstennbl kosstennbl mentioned this issue Feb 12, 2024
Closed
20 tasks
@kosstennbl
Copy link
Collaborator

Should be closed because #1899 had fixed the issue

@HashNuke
Copy link
Collaborator Author

HashNuke commented Mar 4, 2024

Issue-1884 and the associated PR-1899 closes this issue.

No verification required since it's part of Issue-1884. Closing issue.

@HashNuke HashNuke closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylor taylor

@HashNuke HashNuke

@agentpoyo agentpoyo

Labels
bug Something isn't working
Projects
CNF Test Suite
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix output for elastic and db persistence tests kosstennbl/cnf-testsuite
4 participants
@taylor @HashNuke @agentpoyo @kosstennbl