Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes for v1.14.0 #1404

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Release notes for v1.14.0 #1404

merged 11 commits into from
Jan 31, 2024

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jan 31, 2024 •
edited
Loading

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 31, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 8f0ca17
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65ba5cfb3e4b02000859d2f3
😎 Deploy Preview https://deploy-preview-1404--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wallrj wallrj changed the title WIP: Release notes for v1.14.0 Release notes for v1.14.0 Jan 31, 2024
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@wallrj wallrj force-pushed the release-notes-v1.14.0 branch from 13a781e to 812b21f Compare January 31, 2024 14:13
@wallrj wallrj mentioned this pull request Jan 31, 2024
Closed
73 tasks
wallrj added 3 commits January 31, 2024 14:26
@wallrj
Add startupapicheck to ./scripts/gendocs
122e296 
And remove the ./app|./cmd check which does not work with startupapicheck package

Signed-off-by: Richard Wall <[email protected]>
@wallrj
Update ./scripts/gendocs to use release-1.14
dbf1e30 
Signed-off-by: Richard Wall <[email protected]>
@wallrj
./scripts/gendocs/generate
b101903 
Signed-off-by: Richard Wall <[email protected]>
@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2024
wallrj
wallrj commented Jan 31, 2024
View reviewed changes
content/docs/cli/startupapicheck.md Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated with go run ./cmd/startupapicheck --help

scripts/gendocs/generate-new-import-path-docs
echo "+++ app directory for $2 does not exist, skipping..."
return
fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this check was for and it doesn't work with startupapicheck, which has neither of these sub-directories, so I removed it.

scripts/gendocs/generate-new-import-path-docs
@@ -158,7 +152,7 @@ LATEST_VERSION="docs" # to also upgrade a specific version, use v1.13-docs, v1.1
#genversionwithcli "release-1.12" "v1.12-docs"
#genversionwithcli "release-1.13" "v1.13-docs"

genversionwithcli "master" "$LATEST_VERSION"
genversionwithcli "release-1.14" "$LATEST_VERSION"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the default branch so that it generates exactly the right CLI docs and API docs.
Can be reverted after we release v1.14.0.

content/docs/cli/controller.md Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's easier to read these changes if you choose "Hide whitespace" in the GitHub diff settings.

@wallrj wallrj requested a review from ThatsMrTalbot January 31, 2024 14:36
@inteon
Copy link
Member

inteon commented Jan 31, 2024 •
edited
Loading

👍 I like your release notes a lot @wallrj.
More specifically, I think the security section is very good.

@wallrj
Fix typo
8f0ca17 
Signed-off-by: Richard Wall <[email protected]>
inteon
inteon approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThatsMrTalbot
Copy link
Contributor

/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jan 31, 2024
@jetstack-bot jetstack-bot merged commit 876c35b into cert-manager:release-next Jan 31, 2024
3 of 4 checks passed
@jetstack-bot jetstack-bot mentioned this pull request Jan 31, 2024
Merged
@wallrj wallrj deleted the release-notes-v1.14.0 branch January 31, 2024 14:55
@wallrj
Copy link
Member Author

wallrj commented Jan 31, 2024

Thanks both.

@jetstack-bot jetstack-bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon approved these changes

@ThatsMrTalbot ThatsMrTalbot Awaiting requested review from ThatsMrTalbot

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wallrj @inteon @ThatsMrTalbot @jetstack-bot