Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release cert-manager 1.14 #1400

Merged
merged 297 commits into from
Feb 2, 2024
Merged

Release cert-manager 1.14 #1400

merged 297 commits into from
Feb 2, 2024

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jan 26, 2024

Preview: https://release-next--cert-manager-website.netlify.app/docs/releases/release-notes/release-notes-1.14

To be merged during the release of v1.14.0

  • Release notes
  • Documentation for new features
  • Tutorials that depend on cert-manager 1.14

Compy and others added 30 commits January 18, 2024 11:10
Signed-off-by: Tim Ramlot <[email protected]>
I forgot to add the source in [1]. Or rather, I had embedded the source
inside the PNG file, which is surprising to anyone who wants to make
changes to the diagram. As I explained in [2], let's have the source
directly checked in Git.

[1]: #582
[2]: #426

Signed-off-by: Maël Valais <[email protected]>
Signed-off-by: CodingWizKid <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Signed-off-by: Tim Ramlot <[email protected]>
Cluster issuer will look for the secret in the namespace where cert-manager is installed

Co-authored-by: Erik Godding Boye <[email protected]>
Signed-off-by: Nicolas Pais <[email protected]>
This page has a lot of prose which I think benefits from clarification.
There are also many typos and the first section of our installation
instructions talks about an ancient Kubernetes version, with
instructions which will apply to approximately nobody.

This PR should hopefully make the docs simpler and easier to follow.

Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
wallrj and others added 7 commits February 2, 2024 15:33
Release notes for v1.14.1 including explanation for the failed v1.14.0 release
Co-authored-by: Tim Ramlot <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Co-authored-by: Tim Ramlot <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Announce the new cmctl repo on GitHub
@jetstack-bot
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wallrj
Copy link
Member Author

wallrj commented Feb 2, 2024

/override dco

@jetstack-bot
Copy link
Contributor

@wallrj: Overrode contexts on behalf of wallrj: dco

In response to this:

/override dco

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 2, 2024
@wallrj
Copy link
Member Author

wallrj commented Feb 2, 2024

/approve
/lgtm

@jetstack-bot
Copy link
Contributor

@wallrj: you cannot LGTM your own PR.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@inteon
Copy link
Member

inteon commented Feb 2, 2024

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@wallrj
Copy link
Member Author

wallrj commented Feb 2, 2024

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@jetstack-bot jetstack-bot merged commit bb91bb9 into master Feb 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.