Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes for v1.14.1 including explanation for the failed v1.14.0 release #1411

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Feb 2, 2024

Preview: https://deploy-preview-1411--cert-manager-website.netlify.app/docs/releases/release-notes/release-notes-1.14

Updating versions for forthcoming patch release v1.14.1

Part of:

/hold until release is published.

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2024
@wallrj wallrj changed the base branch from master to release-next February 2, 2024 13:19
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 2, 2024
@cert-manager cert-manager deleted a comment from jetstack-bot Feb 2, 2024
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 5dec34b
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65bd0b93ee3453000832f450
😎 Deploy Preview https://deploy-preview-1411--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Richard Wall <[email protected]>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 2, 2024
Signed-off-by: Richard Wall <[email protected]>
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2024
@wallrj wallrj requested a review from inteon February 2, 2024 14:15
@wallrj wallrj changed the title Release v1.14.1 Release notes for v1.14.1 including explanation for the failed v1.14.0 release Feb 2, 2024
- Fix bug in cmctl namespace detection which prevented it being used as a startupapicheck image in namespaces other than cert-manager. ([#6706](https://github.com/cert-manager/cert-manager/pull/6706), [@inteon](https://github.com/inteon))
- Fix bug in cmctl which caused `cmctl experimental install` to panic. ([#6706](https://github.com/cert-manager/cert-manager/pull/6706), [@inteon](https://github.com/inteon))

### Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section can be removed probably.

Signed-off-by: Richard Wall <[email protected]>
@wallrj wallrj requested a review from inteon February 2, 2024 15:01
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@wallrj
Copy link
Member Author

wallrj commented Feb 2, 2024

/unhold

This is merging into release-next, which will then be merged to master in #1400. That PR is the one on hold until the release.

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@inteon
Copy link
Member

inteon commented Feb 2, 2024

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@jetstack-bot jetstack-bot merged commit 9250665 into cert-manager:release-next Feb 2, 2024
4 checks passed
@wallrj wallrj deleted the release-v1.14.1 branch February 2, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants