Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored system configuration service for improved structure and asynchronicity #346

Merged
merged 7 commits into from
Mar 8, 2024

Cleanup system configuration refactor.

53ee9c6
Select commit
Loading
Failed to load commit list.
Merged

Refactored system configuration service for improved structure and asynchronicity #346

Cleanup system configuration refactor.
53ee9c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 8, 2024 in 1s

70.50% (+0.11%) compared to 7f3178d

View this Pull Request on Codecov

70.50% (+0.11%) compared to 7f3178d

Details

Codecov Report

Attention: Patch coverage is 82.22222% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 70.50%. Comparing base (7f3178d) to head (53ee9c6).
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/system-configuration-service.js 80.76% 10 Missing ⚠️
app/exceptions/index.js 81.39% 8 Missing ⚠️
app/lib/database-configuration.js 50.00% 3 Missing ⚠️
app/repository/system-configurations-repository.js 91.17% 3 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##           project-orion     #346      +/-   ##
=================================================
+ Coverage          70.39%   70.50%   +0.11%     
=================================================
  Files                151      152       +1     
  Lines              14373    14445      +72     
  Branches            1660     1674      +14     
=================================================
+ Hits               10118    10185      +67     
- Misses              4245     4250       +5     
  Partials              10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov