Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored system configuration service for improved structure and asynchronicity #346

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Feb 22, 2024

No description provided.

@vsun757 vsun757 requested review from ElJocko and seansica February 22, 2024 14:52
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 70.50%. Comparing base (7f3178d) to head (53ee9c6).
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/system-configuration-service.js 80.76% 10 Missing ⚠️
app/exceptions/index.js 81.39% 8 Missing ⚠️
app/lib/database-configuration.js 50.00% 3 Missing ⚠️
app/repository/system-configurations-repository.js 91.17% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #346      +/-   ##
=================================================
+ Coverage          70.39%   70.50%   +0.11%     
=================================================
  Files                151      152       +1     
  Lines              14373    14445      +72     
  Branches            1660     1674      +14     
=================================================
+ Hits               10118    10185      +67     
- Misses              4245     4250       +5     
  Partials              10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ElJocko ElJocko merged commit d9b1136 into project-orion Mar 8, 2024
4 checks passed
@ElJocko ElJocko deleted the 291-refactor-system-configuration-service-for-improved-structure-and-asynchronicity branch March 8, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants