Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored system configuration service for improved structure and asynchronicity #346

Merged
merged 7 commits into from
Mar 8, 2024

Cleanup system configuration refactor.

53ee9c6
Select commit
Loading
Failed to load commit list.
Merged

Refactored system configuration service for improved structure and asynchronicity #346

Cleanup system configuration refactor.
53ee9c6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 8, 2024 in 0s

82.22% of diff hit (target 70.39%)

View this Pull Request on Codecov

82.22% of diff hit (target 70.39%)

Annotations

Check warning on line 111 in app/exceptions/index.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/exceptions/index.js#L110-L111 

Added lines #L110 - L111 were not covered by tests

Check warning on line 123 in app/exceptions/index.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/exceptions/index.js#L122-L123 

Added lines #L122 - L123 were not covered by tests

Check warning on line 129 in app/exceptions/index.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/exceptions/index.js#L128-L129 

Added lines #L128 - L129 were not covered by tests

Check warning on line 141 in app/exceptions/index.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/exceptions/index.js#L140-L141 

Added lines #L140 - L141 were not covered by tests

Check warning on line 79 in app/lib/database-configuration.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/lib/database-configuration.js#L79 

Added line #L79 was not covered by tests

Check warning on line 20 in app/repository/system-configurations-repository.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/repository/system-configurations-repository.js#L19-L20 

Added lines #L19 - L20 were not covered by tests

Check warning on line 74 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L74 

Added line #L74 was not covered by tests

Check warning on line 91 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L91 

Added line #L91 was not covered by tests

Check warning on line 141 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L141 

Added line #L141 was not covered by tests

Check warning on line 173 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L172-L173 

Added lines #L172 - L173 were not covered by tests

Check warning on line 187 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L187 

Added line #L187 was not covered by tests

Check warning on line 205 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L205 

Added line #L205 was not covered by tests

Check warning on line 228 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L228 

Added line #L228 was not covered by tests

Check warning on line 241 in app/services/system-configuration-service.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

app/services/system-configuration-service.js#L241 

Added line #L241 was not covered by tests
View more details on Codecov