Various Helm Chart maintenance updates #158
Conversation
Signed-off-by: Jeremy Ho <[email protected]>
Renames variables in secrets template to be more consistent with purpose Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
|
Code Climate has analyzed commit 1ede154 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 51.1% (0.0% change). View more on Code Climate. |
Coverage Report
|
|
👀 |
Signed-off-by: Jeremy Ho <[email protected]>
Signed-off-by: Jeremy Ho <[email protected]>
| @@ -2,7 +2,7 @@ const crypto = require('crypto'); | |||
| const jestJoi = require('jest-joi'); | |||
| expect.extend(jestJoi.matchers); | |||
|
|
|||
| const { Permissions } = require('../../../src/components/constants'); | |||
| const { EMAILREGEX, Permissions } = require('../../../src/components/constants'); | |||
There was a problem hiding this comment.
just wondering, if BCBox needs to validate the email address .. so that it only calls the COMS search endpoint once the email is valid.
is the problem that as the bcbox user types, before the email is valid, it is passing it to coms?
There was a problem hiding this comment.
This is part of Kyle's PR. The regex is being backported from BCBox to here so that it remains in alignment - the Joi email definition isn't sufficiently meeting our needs.
| * Generic email regex modified to require domain of at least 2 characters | ||
| * @see {@link https://emailregex.com/} | ||
| */ | ||
| EMAILREGEX: '^[a-zA-Z0-9.!#$%&’*+/=?^_`{|}~-]+@[a-zA-Z0-9-]+(?:\\.[a-zA-Z0-9-]{2,})+$', |
There was a problem hiding this comment.
Wondering would be better to define the constant like: "EMAIL_REGEX" instead as combined (one word)? In the future we will have a multiple word constant, it might look nicer to split by _
Description
This PR addresses various Helm Chart related issues:
SHOWCASE-3145
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
Currently rebased on top of #157 - please merge this branch to fold in both branches of work.